Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify auto-project detection for PubSub. #1289

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

michelle192837
Copy link
Collaborator

In pubsub v1.32, a breaking change made it so specifying a blank project results in an error, rather than automatically detecting the project as it did before. Instead, specify the sentinel value for detecting the project automatically.

See
https://github.com/googleapis/google-cloud-go/releases/tag/pubsub%2Fv1.32.0.

Note that an update a while back upgraded the pubsub module version from v1.22.2 to v1.33.0.

Verified locally that this change fixes some startup failures that exist on the current images. (This should be fixed the next time images are built and the autobump includes them in configs).

@michelle192837
Copy link
Collaborator Author

/hold

One moment, updating tabulator and summarizer as well

In pubsub v1.32, a breaking change made it so specifying a blank project
results in an error, rather than automatically detecting the project as
it did before. Instead, specify the sentinel value for detecting the
project automatically.

See
https://github.com/googleapis/google-cloud-go/releases/tag/pubsub%2Fv1.32.0.

Note that an update a while back upgraded the pubsub module version from
v1.22.2 to v1.33.0.
@simony-gke
Copy link

/lgtm

Copy link
Contributor

@simony-gke: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@michelle192837
Copy link
Collaborator Author

/hold cancel

Updated all three files and verified that they work with the change.

Copy link
Collaborator

@chases2 chases2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chases2, michelle192837

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [chases2,michelle192837]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 70f4277 into GoogleCloudPlatform:main Sep 17, 2024
5 checks passed
@michelle192837 michelle192837 deleted the pubsub branch September 17, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants