-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify auto-project detection for PubSub. #1289
Specify auto-project detection for PubSub. #1289
Conversation
/hold One moment, updating tabulator and summarizer as well |
5cb2273
to
1d8a569
Compare
In pubsub v1.32, a breaking change made it so specifying a blank project results in an error, rather than automatically detecting the project as it did before. Instead, specify the sentinel value for detecting the project automatically. See https://github.com/googleapis/google-cloud-go/releases/tag/pubsub%2Fv1.32.0. Note that an update a while back upgraded the pubsub module version from v1.22.2 to v1.33.0.
1d8a569
to
2aff760
Compare
/lgtm |
@simony-gke: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold cancel Updated all three files and verified that they work with the change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chases2, michelle192837 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
70f4277
into
GoogleCloudPlatform:main
In pubsub v1.32, a breaking change made it so specifying a blank project results in an error, rather than automatically detecting the project as it did before. Instead, specify the sentinel value for detecting the project automatically.
See
https://github.com/googleapis/google-cloud-go/releases/tag/pubsub%2Fv1.32.0.
Note that an update a while back upgraded the pubsub module version from v1.22.2 to v1.33.0.
Verified locally that this change fixes some startup failures that exist on the current images. (This should be fixed the next time images are built and the autobump includes them in configs).