Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump libraries-bom from 26.5.0 to 26.7.0 #1582

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 9, 2023

Bumps libraries-bom from 26.5.0 to 26.7.0.

Release notes

Sourced from libraries-bom's releases.

v26.7.0

GCP Libraries BOM 26.7.0

Here are the differences from the previous version (26.6.0)

New Addition

  • com.google.cloud:google-iam-policy:1.8.0

The group ID of the following artifacts is com.google.cloud.

Notable Changes

google-cloud-bigquery 2.22.0 (prev: 2.21.0)

  • Add collation for Case sensitive string column (#2490) (3257737)

google-cloud-bigquerystorage 2.31.0 (prev: 2.29.0)

  • Add userClose flag back to StreamWriter (#1973) (4b51acd)

  • Add isDone to JsonWriter to indicate a JsonWriter is no longer usable and needs to be recreated. (#1978) (dc07ed8)

  • Add isUserClosed to indicate that user explicitly closed the StreamWriter (#1983) (abd6627)

google-cloud-pubsublite 1.10.0 (prev: 1.9.4)

google-cloud-spanner 6.36.0 (prev: 6.35.2)

  • Support UNRECOGNIZED types + decode BYTES columns lazily (#2219) (fc721c4)

  • java: Skip fixing poms for special modules (#1744) (#2244) (e7f4b40)

google-cloud-storage 2.18.0 (prev: 2.17.2)

  • Add Storage.BlobWriteOption.{meta,}generation{Not,}Match(long) methods to allow literal value construction (#1875) (a9fab09)
  • Setting up 2.15.x (#1880) (1c88e83)

Other libraries

  • [aiplatform] add service_networking.proto to aiplatform v1 (#9073) (3cebec3)

  • [dialogflow-cx] added JSON_PACKAGE field to ExportAgentRequest (#9025) (10bb0cb)

  • [documentai] added advanced_ocr_options field in OcrConfig (#9042) (f845147)

  • [gke-multi-cloud] Added support for Azure workload identity federation (#9055) (374fd84)

  • [certificatemanager] workaround crashes in gRPC for C++ (#9033) (2bf4ad6)

  • [networkconnectivity] remove policy based routing API (#9036) (20c36b2)

  • [tpu] proper http bindings for v2 API (#9035) (ec05dad)

  • Outdated versioning info in README.md (#979) (b92c43b)

Version Upgrades

Minor Version Upgrades

... (truncated)

Changelog

Sourced from libraries-bom's changelog.

26.7.0 (2023-02-09)

Dependencies

  • update dependency com.google.cloud:first-party-dependencies to v3.2.0 (#5796) (e8423fb)
  • update dependency com.google.cloud:gapic-libraries-bom to v1.4.0 (#5797) (2796419)
  • update dependency com.google.cloud:google-cloud-bigquery to v2.22.0 (#5812) (8577ff0)
  • update dependency com.google.cloud:google-cloud-bigquerystorage-bom to v2.30.0 (#5803) (db87371)
  • update dependency com.google.cloud:google-cloud-bigquerystorage-bom to v2.31.0 (#5810) (938b410)
  • update dependency com.google.cloud:google-cloud-bigtable-bom to v2.18.4 (#5800) (6332307)
  • update dependency com.google.cloud:google-cloud-datastore-bom to v2.13.4 (#5799) (af0a88b)
  • update dependency com.google.cloud:google-cloud-firestore-bom to v3.7.10 (#5801) (a547f7e)
  • update dependency com.google.cloud:google-cloud-firestore-bom to v3.7.9 (#5790) (d6c5618)
  • update dependency com.google.cloud:google-cloud-logging-bom to v3.14.3 (#5806) (3ffb805)
  • update dependency com.google.cloud:google-cloud-logging-logback to v0.130.4-alpha (#5787) (0712f4f)
  • update dependency com.google.cloud:google-cloud-nio to v0.126.4 (#5805) (b04bcbf)
  • update dependency com.google.cloud:google-cloud-pubsub-bom to v1.123.2 (#5802) (cf6aa46)
  • update dependency com.google.cloud:google-cloud-pubsublite-bom to v1.10.0 (#5808) (f865d16)
  • update dependency com.google.cloud:google-cloud-spanner-bom to v6.36.0 (#5809) (4901e3f)
  • update dependency com.google.cloud:google-cloud-spanner-jdbc to v2.9.4 (#5811) (3bc6cee)
  • update dependency com.google.cloud:google-cloud-storage-bom to v2.18.0 (#5804) (38fa799)

26.5.1 (2023-02-02)

Bug Fixes

  • README.md to follow java-cloud-bom release (d1b42b4)

Dependencies

  • update dependency com.google.cloud:google-cloud-bigquerystorage-bom to v2.29.0 (#5793) (d572679)
Commits
  • 00de58c chore: release main (#5795)
  • 83ee472 build(deps): update dependency org.apache.maven.plugins:maven-deploy-plugin t...
  • 0712f4f deps: update dependency com.google.cloud:google-cloud-logging-logback to v0.1...
  • 8577ff0 deps: update dependency com.google.cloud:google-cloud-bigquery to v2.22.0 (#5...
  • 3bc6cee deps: update dependency com.google.cloud:google-cloud-spanner-jdbc to v2.9.4 ...
  • 6013d29 build(deps): update dependency org.apache.maven:maven-artifact to v3.9.0 (#5798)
  • d323442 build(deps): update dependency org.apache.maven.plugins:maven-enforcer-plugin...
  • 938b410 deps: update dependency com.google.cloud:google-cloud-bigquerystorage-bom to ...
  • 4901e3f deps: update dependency com.google.cloud:google-cloud-spanner-bom to v6.36.0 ...
  • f865d16 deps: update dependency com.google.cloud:google-cloud-pubsublite-bom to v1.10...
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [libraries-bom](https://github.com/googleapis/java-cloud-bom) from 26.5.0 to 26.7.0.
- [Release notes](https://github.com/googleapis/java-cloud-bom/releases)
- [Changelog](https://github.com/googleapis/java-cloud-bom/blob/main/CHANGELOG.md)
- [Commits](googleapis/java-cloud-bom@v26.5.0...v26.7.0)

---
updated-dependencies:
- dependency-name: com.google.cloud:libraries-bom
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Feb 9, 2023
@emmileaf
Copy link
Contributor

emmileaf commented Feb 9, 2023

The compilation failure coming from spring-cloud-preview modules corresponds to some underlying client library changes.

  1. The networkconnectivity library’s breaking change in fix!: [networkconnectivity] remove policy based routing API googleapis/google-cloud-java#9036.
Error: /home/runner/work/spring-cloud-gcp/spring-cloud-gcp/spring-cloud-previews/google-cloud-networkconnectivity-spring-starter/src/main/java/com/google/cloud/networkconnectivity/v1/spring/PolicyBasedRoutingServiceSpringAutoConfiguration.java:[25,47] cannot find symbol

Error:   symbol:   class PolicyBasedRoutingServiceClient
Error:   location: package com.google.cloud.networkconnectivity.v1

One more issue, after removing these classes and getting past this error:

  1. Some REST-related generated code might need additional alignment with feat: Do not generate Service REST code if there are no matching RPC in a Service googleapis/sdk-platform-java#1236, now that HttpJson references no longer generated for services without enabled REST RPCs.
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project google-cloud-apigee-connect-spring-starter: Compilation failure: Compilation failure: 
[ERROR] spring-cloud-gcp/spring-cloud-previews/google-cloud-apigee-connect-spring-starter/src/main/java/com/google/cloud/apigeeconnect/v1/spring/TetherSpringAutoConfiguration.java:[96,28] cannot find symbol
[ERROR]   symbol:   method defaultHttpJsonTransportProviderBuilder()
[ERROR]   location: class com.google.cloud.apigeeconnect.v1.TetherSettings
[ERROR] spring-cloud-gcp/spring-cloud-previews/google-cloud-apigee-connect-spring-starter/src/main/java/com/google/cloud/apigeeconnect/v1/spring/TetherSpringAutoConfiguration.java:[121,45] cannot find symbol
[ERROR]   symbol:   method newHttpJsonBuilder()
[ERROR]   location: class com.google.cloud.apigeeconnect.v1.TetherSettings

cc/ @mpeddada1, I'll look into the changes needed on the codegen side and try to unblock this PR. Thanks!

@blakeli0
Copy link
Contributor

blakeli0 commented Feb 9, 2023

  1. Some REST-related generated code might need additional alignment with feat: Do not generate Service REST code if there are no matching RPC in a Service googleapis/gapic-generator-java#1236, now that HttpJson references no longer generated for services without enabled REST RPCs.
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project google-cloud-apigee-connect-spring-starter: Compilation failure: Compilation failure: 
[ERROR] spring-cloud-gcp/spring-cloud-previews/google-cloud-apigee-connect-spring-starter/src/main/java/com/google/cloud/apigeeconnect/v1/spring/TetherSpringAutoConfiguration.java:[96,28] cannot find symbol
[ERROR]   symbol:   method defaultHttpJsonTransportProviderBuilder()
[ERROR]   location: class com.google.cloud.apigeeconnect.v1.TetherSettings
[ERROR] spring-cloud-gcp/spring-cloud-previews/google-cloud-apigee-connect-spring-starter/src/main/java/com/google/cloud/apigeeconnect/v1/spring/TetherSpringAutoConfiguration.java:[121,45] cannot find symbol
[ERROR]   symbol:   method newHttpJsonBuilder()
[ERROR]   location: class com.google.cloud.apigeeconnect.v1.TetherSettings

The easiest approach is probably to duplicate the logic in Service and Method, then check if a service has any Http eligible RPCs before generating these Http specific builders.

@emmileaf
Copy link
Contributor

emmileaf commented Feb 9, 2023

Update: this PR can be superseded by #1586 (containing a manual version bump), given the compilation conflicts.

@mpeddada1
Copy link
Contributor

Closing this PR in favor of #1586

@mpeddada1 mpeddada1 closed this Feb 9, 2023
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 9, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/maven/com.google.cloud-libraries-bom-26.7.0 branch February 9, 2023 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants