Fixing coverage #63
Merged
Fixing coverage #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elibixby I'm gonna go ahead and merge this since it doesn't affect any code. Let me know if you have any issues and I'll follow up. |
|
SGTM Deleting branch |
nicain
pushed a commit
that referenced
this pull request
Nov 2, 2022
Fixes #62 🦕 Current version of sample doesnt check if blob is directory or .json file. Then, it downloads as bytes and tries to parse json from the dir blob file which will cause error.
8 tasks
ivanmkc
pushed a commit
that referenced
this pull request
Nov 3, 2022
* docs(python): update intersphinx for grpc and auth * docs(python): update intersphinx for grpc and auth * use https for python intersphinx Co-authored-by: Tim Swast <swast@google.com> Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com> Source-Date: Wed Nov 18 14:37:25 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: 9a7d9fbb7045c34c9d3d22c1ff766eeae51f04c9 Source-Link: googleapis/synthtool@9a7d9fb * docs(python): fix intersphinx link for google-auth Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com> Source-Date: Thu Nov 19 10:16:05 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: a073c873f3928c561bdf87fdfbf1d081d1998984 Source-Link: googleapis/synthtool@a073c87 * chore: add config / docs for 'pre-commit' support Source-Author: Tres Seaver <tseaver@palladion.com> Source-Date: Tue Dec 1 16:01:20 2020 -0500 Source-Repo: googleapis/synthtool Source-Sha: 32af6da519a6b042e3da62008e2a75e991efb6b4 Source-Link: googleapis/synthtool@32af6da * chore(deps): update precommit hook pre-commit/pre-commit-hooks to v3.3.0 Source-Author: WhiteSource Renovate <bot@renovateapp.com> Source-Date: Wed Dec 2 17:18:24 2020 +0100 Source-Repo: googleapis/synthtool Source-Sha: 69629b64b83c6421d616be2b8e11795738ec8a6c Source-Link: googleapis/synthtool@69629b6 * test(python): give filesystem paths to pytest-cov https://pytest-cov.readthedocs.io/en/latest/config.html The pytest-cov docs seem to suggest a filesystem path is expected. Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com> Source-Date: Wed Dec 2 09:28:04 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: f94318521f63085b9ccb43d42af89f153fb39f15 Source-Link: googleapis/synthtool@f943185 * chore: update noxfile.py.j2 * Update noxfile.py.j2 add changes from @glasnt to the template template to ensure that enforcing type hinting doesn't fail for repos with the sample noxfile (aka all samples repos) See https://github.com/GoogleCloudPlatform/python-docs-samples/pull/4869/files for context * fix typo Source-Author: Leah E. Cole <6719667+leahecole@users.noreply.github.com> Source-Date: Thu Dec 3 13:44:30 2020 -0800 Source-Repo: googleapis/synthtool Source-Sha: 18c5dbdb4ac8cf75d4d8174e7b4558f48e76f8a1 Source-Link: googleapis/synthtool@18c5dbd * chore(deps): update precommit hook pre-commit/pre-commit-hooks to v3.4.0 Co-authored-by: Tres Seaver <tseaver@palladion.com> Source-Author: WhiteSource Renovate <bot@renovateapp.com> Source-Date: Wed Dec 16 18:13:24 2020 +0100 Source-Repo: googleapis/synthtool Source-Sha: aa255b15d52b6d8950cca48cfdf58f7d27a60c8a Source-Link: googleapis/synthtool@aa255b1 * docs(python): document adding Python 3.9 support, dropping 3.5 support Closes #787 Source-Author: Tres Seaver <tseaver@palladion.com> Source-Date: Thu Dec 17 16:08:02 2020 -0500 Source-Repo: googleapis/synthtool Source-Sha: b670a77a454f415d247907908e8ee7943e06d718 Source-Link: googleapis/synthtool@b670a77 * chore: exclude `.nox` directories from linting The samples tests create `.nox` directories with all dependencies installed. These directories should be excluded from linting. I've tested this change locally, and it significantly speeds up linting on my machine. Source-Author: Tim Swast <swast@google.com> Source-Date: Tue Dec 22 13:04:04 2020 -0600 Source-Repo: googleapis/synthtool Source-Sha: 373861061648b5fe5e0ac4f8a38b32d639ee93e4 Source-Link: googleapis/synthtool@3738610
8 tasks
ivanmkc
pushed a commit
that referenced
this pull request
Nov 4, 2022
* docs(python): update intersphinx for grpc and auth * docs(python): update intersphinx for grpc and auth * use https for python intersphinx Co-authored-by: Tim Swast <swast@google.com> Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com> Source-Date: Wed Nov 18 14:37:25 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: 9a7d9fbb7045c34c9d3d22c1ff766eeae51f04c9 Source-Link: googleapis/synthtool@9a7d9fb * docs(python): fix intersphinx link for google-auth Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com> Source-Date: Thu Nov 19 10:16:05 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: a073c873f3928c561bdf87fdfbf1d081d1998984 Source-Link: googleapis/synthtool@a073c87 * chore: add config / docs for 'pre-commit' support Source-Author: Tres Seaver <tseaver@palladion.com> Source-Date: Tue Dec 1 16:01:20 2020 -0500 Source-Repo: googleapis/synthtool Source-Sha: 32af6da519a6b042e3da62008e2a75e991efb6b4 Source-Link: googleapis/synthtool@32af6da * chore(deps): update precommit hook pre-commit/pre-commit-hooks to v3.3.0 Source-Author: WhiteSource Renovate <bot@renovateapp.com> Source-Date: Wed Dec 2 17:18:24 2020 +0100 Source-Repo: googleapis/synthtool Source-Sha: 69629b64b83c6421d616be2b8e11795738ec8a6c Source-Link: googleapis/synthtool@69629b6 * test(python): give filesystem paths to pytest-cov https://pytest-cov.readthedocs.io/en/latest/config.html The pytest-cov docs seem to suggest a filesystem path is expected. Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com> Source-Date: Wed Dec 2 09:28:04 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: f94318521f63085b9ccb43d42af89f153fb39f15 Source-Link: googleapis/synthtool@f943185 * chore: update noxfile.py.j2 * Update noxfile.py.j2 add changes from @glasnt to the template template to ensure that enforcing type hinting doesn't fail for repos with the sample noxfile (aka all samples repos) See https://github.com/GoogleCloudPlatform/python-docs-samples/pull/4869/files for context * fix typo Source-Author: Leah E. Cole <6719667+leahecole@users.noreply.github.com> Source-Date: Thu Dec 3 13:44:30 2020 -0800 Source-Repo: googleapis/synthtool Source-Sha: 18c5dbdb4ac8cf75d4d8174e7b4558f48e76f8a1 Source-Link: googleapis/synthtool@18c5dbd * chore(deps): update precommit hook pre-commit/pre-commit-hooks to v3.4.0 Co-authored-by: Tres Seaver <tseaver@palladion.com> Source-Author: WhiteSource Renovate <bot@renovateapp.com> Source-Date: Wed Dec 16 18:13:24 2020 +0100 Source-Repo: googleapis/synthtool Source-Sha: aa255b15d52b6d8950cca48cfdf58f7d27a60c8a Source-Link: googleapis/synthtool@aa255b1 * docs(python): document adding Python 3.9 support, dropping 3.5 support Closes #787 Source-Author: Tres Seaver <tseaver@palladion.com> Source-Date: Thu Dec 17 16:08:02 2020 -0500 Source-Repo: googleapis/synthtool Source-Sha: b670a77a454f415d247907908e8ee7943e06d718 Source-Link: googleapis/synthtool@b670a77 * chore: exclude `.nox` directories from linting The samples tests create `.nox` directories with all dependencies installed. These directories should be excluded from linting. I've tested this change locally, and it significantly speeds up linting on my machine. Source-Author: Tim Swast <swast@google.com> Source-Date: Tue Dec 22 13:04:04 2020 -0600 Source-Repo: googleapis/synthtool Source-Sha: 373861061648b5fe5e0ac4f8a38b32d639ee93e4 Source-Link: googleapis/synthtool@3738610
msampathkumar
pushed a commit
that referenced
this pull request
Nov 9, 2022
8 tasks
msampathkumar
pushed a commit
that referenced
this pull request
Nov 9, 2022
8 tasks
donmccasland
pushed a commit
that referenced
this pull request
Nov 11, 2022
* fix(sample): fix a broken test fixes #59
8 tasks
dandhlee
pushed a commit
that referenced
this pull request
Nov 15, 2022
8 tasks
telpirion
pushed a commit
that referenced
this pull request
Nov 16, 2022
msampathkumar
pushed a commit
that referenced
this pull request
Nov 17, 2022
dandhlee
pushed a commit
that referenced
this pull request
Nov 18, 2022
engelke
pushed a commit
that referenced
this pull request
Nov 28, 2022
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [google-cloud-storage](https://github.com/googleapis/python-storage) | minor | `==1.29.0` -> `==1.30.0` | --- ### Release Notes <details> <summary>googleapis/python-storage</summary> ### [`v1.30.0`](https://github.com/googleapis/python-storage/blob/master/CHANGELOG.md#​1300-httpswwwgithubcomgoogleapispython-storagecomparev1290v1300-2020-07-24) [Compare Source](https://github.com/googleapis/python-storage/compare/v1.29.0...v1.30.0) ##### Features - add timeouts to Blob methods where missing ([#​185](https://github.com/googleapis/python-storage/issues/185)) ([6eeb855](https://github.com/googleapis/python-storage/commit/6eeb855aa0e6a7835d1d4f6e72951e43af22ab57)) - auto-populate standard headers for non-chunked downloads ([#​204](https://github.com/googleapis/python-storage/issues/204)) ([d8432cd](https://github.com/googleapis/python-storage/commit/d8432cd65a4e9b38eebd1ade2ff00f2f44bb0ef6)), closes [#​24](https://github.com/googleapis/python-storage/issues/24) - migrate to Service Account Credentials API ([#​189](https://github.com/googleapis/python-storage/issues/189)) ([e4990d0](https://github.com/googleapis/python-storage/commit/e4990d06043dbd8d1a417f3a1a67fe8746071f1c)) ##### Bug Fixes - add multiprocessing.rst to synthool excludes ([#​186](https://github.com/googleapis/python-storage/issues/186)) ([4d76e38](https://github.com/googleapis/python-storage/commit/4d76e3882210ed2818a43256265f6df31348d410)) ##### Documentation - fix indent in code blocks ([#​171](https://github.com/googleapis/python-storage/issues/171)) ([62d1543](https://github.com/googleapis/python-storage/commit/62d1543e18040b286b23464562aa6eb998074c54)), closes [#​170](https://github.com/googleapis/python-storage/issues/170) - remove doubled word in docstring ([#​209](https://github.com/googleapis/python-storage/issues/209)) ([7a4e7a5](https://github.com/googleapis/python-storage/commit/7a4e7a5974abedb0b7b2e110cacbfcd0a40346b6)) ##### Documentation - fix indent in code blocks ([#​171](https://github.com/googleapis/python-storage/issues/171)) ([62d1543](https://github.com/googleapis/python-storage/commit/62d1543e18040b286b23464562aa6eb998074c54)), closes [#​170](https://github.com/googleapis/python-storage/issues/170) - remove doubled word in docstring ([#​209](https://github.com/googleapis/python-storage/issues/209)) ([7a4e7a5](https://github.com/googleapis/python-storage/commit/7a4e7a5974abedb0b7b2e110cacbfcd0a40346b6)) ##### Dependencies - prep for grmp-1.0.0 release ([#​211](https://github.com/googleapis/python-storage/issues/211)) ([55bae9a](https://github.com/googleapis/python-storage/commit/55bae9a0e7c0db512c10c6b3b621cd2ef05c9729)) </details> --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/python-asset).
dandhlee
pushed a commit
that referenced
this pull request
Nov 29, 2022
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [google-cloud-storage](https://github.com/googleapis/python-storage) | minor | `==1.29.0` -> `==1.30.0` | --- ### Release Notes <details> <summary>googleapis/python-storage</summary> ### [`v1.30.0`](https://github.com/googleapis/python-storage/blob/master/CHANGELOG.md#​1300-httpswwwgithubcomgoogleapispython-storagecomparev1290v1300-2020-07-24) [Compare Source](https://github.com/googleapis/python-storage/compare/v1.29.0...v1.30.0) ##### Features - add timeouts to Blob methods where missing ([#​185](https://github.com/googleapis/python-storage/issues/185)) ([6eeb855](https://github.com/googleapis/python-storage/commit/6eeb855aa0e6a7835d1d4f6e72951e43af22ab57)) - auto-populate standard headers for non-chunked downloads ([#​204](https://github.com/googleapis/python-storage/issues/204)) ([d8432cd](https://github.com/googleapis/python-storage/commit/d8432cd65a4e9b38eebd1ade2ff00f2f44bb0ef6)), closes [#​24](https://github.com/googleapis/python-storage/issues/24) - migrate to Service Account Credentials API ([#​189](https://github.com/googleapis/python-storage/issues/189)) ([e4990d0](https://github.com/googleapis/python-storage/commit/e4990d06043dbd8d1a417f3a1a67fe8746071f1c)) ##### Bug Fixes - add multiprocessing.rst to synthool excludes ([#​186](https://github.com/googleapis/python-storage/issues/186)) ([4d76e38](https://github.com/googleapis/python-storage/commit/4d76e3882210ed2818a43256265f6df31348d410)) ##### Documentation - fix indent in code blocks ([#​171](https://github.com/googleapis/python-storage/issues/171)) ([62d1543](https://github.com/googleapis/python-storage/commit/62d1543e18040b286b23464562aa6eb998074c54)), closes [#​170](https://github.com/googleapis/python-storage/issues/170) - remove doubled word in docstring ([#​209](https://github.com/googleapis/python-storage/issues/209)) ([7a4e7a5](https://github.com/googleapis/python-storage/commit/7a4e7a5974abedb0b7b2e110cacbfcd0a40346b6)) ##### Documentation - fix indent in code blocks ([#​171](https://github.com/googleapis/python-storage/issues/171)) ([62d1543](https://github.com/googleapis/python-storage/commit/62d1543e18040b286b23464562aa6eb998074c54)), closes [#​170](https://github.com/googleapis/python-storage/issues/170) - remove doubled word in docstring ([#​209](https://github.com/googleapis/python-storage/issues/209)) ([7a4e7a5](https://github.com/googleapis/python-storage/commit/7a4e7a5974abedb0b7b2e110cacbfcd0a40346b6)) ##### Dependencies - prep for grmp-1.0.0 release ([#​211](https://github.com/googleapis/python-storage/issues/211)) ([55bae9a](https://github.com/googleapis/python-storage/commit/55bae9a0e7c0db512c10c6b3b621cd2ef05c9729)) </details> --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/python-asset).
holtskinner
pushed a commit
that referenced
this pull request
Jan 3, 2023
Fixes #62 🦕 Current version of sample doesnt check if blob is directory or .json file. Then, it downloads as bytes and tries to parse json from the dir blob file which will cause error.
holtskinner
pushed a commit
that referenced
this pull request
Jan 4, 2023
Fixes #62 🦕 Current version of sample doesnt check if blob is directory or .json file. Then, it downloads as bytes and tries to parse json from the dir blob file which will cause error.
8 tasks
dandhlee
pushed a commit
that referenced
this pull request
Jan 5, 2023
Fixes #62 🦕 Current version of sample doesnt check if blob is directory or .json file. Then, it downloads as bytes and tries to parse json from the dir blob file which will cause error.
dandhlee
pushed a commit
that referenced
this pull request
Jan 26, 2023
* fix(sample): fix a broken test fixes #59
telpirion
pushed a commit
that referenced
this pull request
Mar 13, 2023
* fix(sample): fix a broken test fixes #59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@elibixby this fixes coverage and tests runs now that gae and py27 are separate environments.