-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Scipy example #474
Add Scipy example #474
Conversation
Hmm |
I also love scipy! |
test3 |
Starting a new build on Jenkins! |
test4 |
Build finished. |
@@ -19,3 +19,4 @@ secrets.tar | |||
junit.xml | |||
credentials.dat | |||
.nox | |||
appengine/flexible/scipy/assets/resized_google_logo.jpg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just add this to the .gitignore in /appengine/flexible/scipy
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
app_path = os.path.dirname(os.path.realpath(__file__)) | ||
image_path = os.path.join(app_path, 'assets/google_logo.jpg') | ||
img = scipy.misc.imread(image_path) | ||
img_tinted = scipy.misc.imresize(img, (300, 300)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps img_resized
instead? Also, update the comment in line 34
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's been merged and Bill's at burning man, man. Send a PR if you feel strongly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just catching up on email 😅
img = scipy.misc.imread(image_path) | ||
img_tinted = scipy.misc.imresize(img, (300, 300)) | ||
output_image_path = os.path.join( | ||
app_path, 'assets/resized_google_logo.jpg') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably unnecessary to have the resized file checked in, since that's what you're generating..
* feat: Add support for python 3.11 chore: Update gapic-generator-python to v1.8.0 PiperOrigin-RevId: 500768693 Source-Link: googleapis/googleapis@190b612 Source-Link: https://github.com/googleapis/googleapis-gen/commit/7bf29a414b9ecac3170f0b65bdc2a95705c0ef1a Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiN2JmMjlhNDE0YjllY2FjMzE3MGYwYjY1YmRjMmE5NTcwNWMwZWYxYSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
I tried to keep this pretty simple just to demonstrate it works on Flex.
Could use GCS to make it a little less clumsy but leaned towards simplicity.