Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add initial Secret Manager samples #2664

Merged
merged 6 commits into from
Dec 30, 2019
Merged

Add initial Secret Manager samples #2664

merged 6 commits into from
Dec 30, 2019

Conversation

sethvargo
Copy link
Member

Add initial Secret Manager samples

@sethvargo sethvargo requested a review from a team as a code owner December 27, 2019 22:30
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 27, 2019
@kurtisvg kurtisvg added the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 27, 2019
@sethvargo
Copy link
Member Author

Can someone please enable the Secret Manager API on the test project(s):

gcloud services enable secretmanager.googleapis.com

@kurtisvg
Copy link
Contributor

Can someone please enable the Secret Manager API on the test project(s):

gcloud services enable secretmanager.googleapis.com

👍

@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 27, 2019
@kurtisvg kurtisvg added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 28, 2019
@kokoro-team kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 28, 2019
kurtisvg
kurtisvg suggested changes Dec 28, 2019
View reviewed changes
Copy link
Contributor

@kurtisvg kurtisvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there is a problem with quota in the current tests - I tried to request an upgrade but it doesn't look like it'll let me go over 60. Do you know if we can raise this?

Otherwise, would it work to scope a secret (or a few secrets, since some are destroyed) to the module level?

secretmanager/api-client/access_secret_version.py Outdated Show resolved Hide resolved
secretmanager/api-client/create_secret.py Show resolved Hide resolved
secretmanager/api-client/quickstart_test.py Outdated Show resolved Hide resolved
secretmanager/api-client/requirements.txt Outdated Show resolved Hide resolved
secretmanager/api-client/update_secret.py Outdated Show resolved Hide resolved
sethvargo
sethvargo commented Dec 28, 2019
View reviewed changes
Copy link
Member Author

@sethvargo sethvargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated with feedback. Can you send me the project IDs in an email or DM and we can look at increasing the quota please?

kurtisvg
kurtisvg approved these changes Dec 30, 2019
View reviewed changes
Copy link
Contributor

@kurtisvg kurtisvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once tests pass

@kurtisvg kurtisvg added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 30, 2019
@kokoro-team kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 30, 2019
@kurtisvg kurtisvg merged commit ebe1500 into GoogleCloudPlatform:master Dec 30, 2019
@sethvargo sethvargo deleted the sethvargo/secretmanager_samples branch April 10, 2020 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurtisvg kurtisvg kurtisvg approved these changes

Assignees

@kurtisvg kurtisvg

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sethvargo @kurtisvg @googlebot @kokoro-team