Remove unused HTTP functions from scheduleinstance code sample

functions/scheduleinstance/README.md

@@ -22,10 +22,8 @@ See the [Scheduling Instances with Cloud Scheduler tutorial][tutorial].
 
 ## Additional resources
 
-* [Cloud Scheduler documentation][docs]
-* [HTTP Cloud Functions documentation][http_docs]
-* [HTTP Cloud Functions tutorial][http_tutorial]
+* [GCE NodeJS Client Library documentation][compute_nodejs_docs]
+* [Background Cloud Functions documentation][background_functions_docs]
 
-[docs]: https://cloud.google.com/scheduler/docs/
-[http_docs]: https://cloud.google.com/functions/docs/writing/http
-[http_tutorial]: https://cloud.google.com/functions/docs/tutorials/http
+[compute_nodejs_docs]: https://cloud.google.com/compute/docs/tutorials/nodejs-guide
+[background_functions_docs]: https://cloud.google.com/functions/docs/writing/background

functions/scheduleinstance/index.js

@@ -13,101 +13,13 @@
  * limitations under the License.
  */
 
-// [START functions_start_instance_http]
-// [START functions_stop_instance_http]
 // [START functions_start_instance_pubsub]
 // [START functions_stop_instance_pubsub]
 const Buffer = require('safe-buffer').Buffer;
 const Compute = require('@google-cloud/compute');
 const compute = new Compute();
-
-// [END functions_stop_instance_http]
-// [END functions_start_instance_pubsub]
 // [END functions_stop_instance_pubsub]
-/**
- * Starts a Compute Engine instance.
- *
- * Expects an HTTP POST request with a JSON-formatted request body containing
- * the following attributes:
- *  zone - the GCP zone the instance is located in.
- *  instance - the name of the instance.
- *
- * @param {!object} req Cloud Function HTTP request data.
- * @param {!object} res Cloud Function HTTP response data.
- * @returns {!object} Cloud Function response data with status code and message.
- */
-exports.startInstanceHttp = (req, res) => {
-  try {
-    const payload = _validatePayload(_parseHttpPayload(_validateHttpReq(req)));
-    compute.zone(payload.zone)
-      .vm(payload.instance)
-      .start()
-      .then(data => {
-        // Operation pending.
-        const operation = data[0];
-        return operation.promise();
-      })
-      .then(() => {
-        // Operation complete. Instance successfully started.
-        const message = 'Successfully started instance ' + payload.instance;
-        console.log(message);
-        res.status(200).send(message);
-      })
-      .catch(err => {
-        console.log(err);
-        res.status(500).send({error: err.message});
-      });
-  } catch (err) {
-    console.log(err);
-    res.status(400).send({error: err.message});
-  }
-  return res;
-};
-
-// [END functions_start_instance_http]
-// [START functions_stop_instance_http]
-/**
- * Stops a Compute Engine instance.
- *
- * Expects an HTTP POST request with a JSON-formatted request body containing
- * the following attributes:
- *  zone - the GCP zone the instance is located in.
- *  instance - the name of the instance.
- *
- * @param {!object} req Cloud Function HTTP request data.
- * @param {!object} res Cloud Function HTTP response data.
- * @returns {!object} Cloud Function response data with status code and message.
- */
-exports.stopInstanceHttp = (req, res) => {
-  try {
-    const payload = _validatePayload(_parseHttpPayload(_validateHttpReq(req)));
-    compute.zone(payload.zone)
-      .vm(payload.instance)
-      .stop()
-      .then(data => {
-        // Operation pending.
-        const operation = data[0];
-        return operation.promise();
-      })
-      .then(() => {
-        // Operation complete. Instance successfully stopped.
-        const message = 'Successfully stopped instance ' + payload.instance;
-        console.log(message);
-        res.status(200).send(message);
-      })
-      .catch(err => {
-        console.log(err);
-        res.status(500).send({error: err.message});
-      });
-  } catch (err) {
-    console.log(err);
-    res.status(400).send({error: err.message});
-  }
-  return res;
-};
 
-// [END functions_stop_instance_http]
-// [START functions_start_instance_pubsub]
 /**
  * Starts a Compute Engine instance.
  *
@@ -146,9 +58,9 @@ exports.startInstancePubSub = (event, callback) => {
     callback(err);
   }
 };
-
 // [END functions_start_instance_pubsub]
 // [START functions_stop_instance_pubsub]
+
 /**
  * Stops a Compute Engine instance.
  *
@@ -187,10 +99,8 @@ exports.stopInstancePubSub = (event, callback) => {
     callback(err);
   }
 };
-
-// [START functions_start_instance_http]
-// [START functions_stop_instance_http]
 // [START functions_start_instance_pubsub]
+
 /**
  * Validates that a request payload contains the expected fields.
  *
@@ -207,41 +117,3 @@ function _validatePayload (payload) {
 }
 // [END functions_start_instance_pubsub]
 // [END functions_stop_instance_pubsub]
-
-/**
- * Parses the request payload of an HTTP request based on content-type.
- *
- * @param {!object} req a Cloud Functions HTTP request object.
- * @returns {!object} an object with attributes matching the request payload.
- */
-function _parseHttpPayload (req) {
-  const contentType = req.get('content-type');
-  if (contentType === 'application/json') {
-    // Request.body automatically parsed as an object.
-    return req.body;
-  } else if (contentType === 'application/octet-stream') {
-    // Convert buffer to a string and parse as JSON string.
-    return JSON.parse(req.body.toString());
-  } else {
-    throw new Error('Unsupported HTTP content-type ' + req.get('content-type') +
-        '; use application/json or application/octet-stream');
-  }
-}
-
-/**
- * Validates that a HTTP request contains the expected fields.
- *
- * @param {!object} req the request to validate.
- * @returns {!object} the request object.
- */
-function _validateHttpReq (req) {
-  if (req.method !== 'POST') {
-    throw new Error('Unsupported HTTP method ' + req.method +
-        '; use method POST');
-  } else if (typeof req.get('content-type') === 'undefined') {
-    throw new Error('HTTP content-type missing');
-  }
-  return req;
-}
-// [END functions_start_instance_http]
-// [END functions_stop_instance_http]