Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

functions: method not implemented should use 405 #764

Merged
merged 5 commits into from
Nov 8, 2018

Conversation

grayside
Copy link
Collaborator

No description provided.

@grayside grayside requested a review from ace-n October 11, 2018 18:53
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 11, 2018
@ace-n
Copy link
Contributor

ace-n commented Oct 16, 2018

The tests are failing - can you update them as well?

@ace-n
Copy link
Contributor

ace-n commented Oct 17, 2018

@dpebot merge when green

@dpebot
Copy link
Contributor

dpebot commented Oct 17, 2018

Okay! I'll merge when all statuses are green and all reviewers approve.

@dpebot dpebot added the automerge Merge the pull request once unit tests and other checks pass. label Oct 17, 2018
@dpebot dpebot self-assigned this Oct 17, 2018
@grayside
Copy link
Collaborator Author

Failing test seems like an unrelated lint error.

@fhinkel fhinkel merged commit 8d0b656 into master Nov 8, 2018
@fhinkel fhinkel deleted the grayside-functions-405 branch November 8, 2018 16:09
grayside pushed a commit that referenced this pull request Nov 11, 2022
ace-n pushed a commit that referenced this pull request Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants