Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document 'callback' parameter name in @param #417

Merged
merged 1 commit into from
Jul 7, 2017
Merged

Conversation

ace-n
Copy link
Contributor

@ace-n ace-n commented Jul 5, 2017

No description provided.

@ace-n ace-n requested a review from jmdobry July 5, 2017 21:09
@codecov-io
Copy link

Codecov Report

Merging #417 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #417   +/-   ##
=======================================
  Coverage   83.88%   83.88%           
=======================================
  Files           4        4           
  Lines         422      422           
=======================================
  Hits          354      354           
  Misses         68       68

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43782fe...a3ae228. Read the comment docs.

@jmdobry jmdobry merged commit 8867ca3 into master Jul 7, 2017
@jmdobry jmdobry deleted the add-param-names branch July 7, 2017 17:11
ace-n pushed a commit that referenced this pull request Nov 14, 2022
🤖 I have created a release \*beep\* \*boop\* 
---
## [2.0.0](https://github.com/googleapis/nodejs-compute/compare/v1.2.0...v2.0.0) (2020-05-08)


### ⚠ BREAKING CHANGES

* update to latest version of gts and typescript (#433)
* require node 10 in engines field (#431)

### Features

* require node 10 in engines field ([#431](https://github.com/googleapis/nodejs-compute/issues/431)) ([fe2897f](https://github.com/googleapis/nodejs-compute/commit/fe2897fd1d625df0ccf5b910ec850e761c2ed6d3))


### Bug Fixes

* apache license URL ([#468](https://github.com/googleapis/nodejs-compute/issues/468)) ([#427](https://github.com/googleapis/nodejs-compute/issues/427)) ([02d63ed](https://github.com/googleapis/nodejs-compute/commit/02d63ed5a5a3559be0b5e49ed4c771b3661518a1))
* **deps:** update dependency @google-cloud/common to v3 ([#421](https://github.com/googleapis/nodejs-compute/issues/421)) ([d4469b6](https://github.com/googleapis/nodejs-compute/commit/d4469b693745df5a8a36b6988b7dba98f7d55142))
* **deps:** update dependency @google-cloud/paginator to v3 ([#419](https://github.com/googleapis/nodejs-compute/issues/419)) ([e667aee](https://github.com/googleapis/nodejs-compute/commit/e667aeecf7b9f51875c06cb6a885040828dc1181))
* **deps:** update dependency @google-cloud/projectify to v2 ([#418](https://github.com/googleapis/nodejs-compute/issues/418)) ([b861540](https://github.com/googleapis/nodejs-compute/commit/b861540aa17118a7508c7c970d84864a9028f588))
* **deps:** update dependency @google-cloud/promisify to v2 ([#417](https://github.com/googleapis/nodejs-compute/issues/417)) ([eedce75](https://github.com/googleapis/nodejs-compute/commit/eedce75e0d3f10dfed8151f12150d38d032f6a27))
* **deps:** update dependency @sendgrid/mail to v7 ([#424](https://github.com/googleapis/nodejs-compute/issues/424)) ([17af0f4](https://github.com/googleapis/nodejs-compute/commit/17af0f425354b261f9afc8ab30e16e66b7193fec))


### Build System

* update to latest version of gts and typescript ([#433](https://github.com/googleapis/nodejs-compute/issues/433)) ([a4fa8cc](https://github.com/googleapis/nodejs-compute/commit/a4fa8cc21df7a894486832b05449fa7afc02b7ee))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
kweinmeister pushed a commit that referenced this pull request Nov 18, 2022
ace-n pushed a commit that referenced this pull request Nov 21, 2022
🤖 I have created a release \*beep\* \*boop\* 
---
## [2.0.0](https://github.com/googleapis/nodejs-compute/compare/v1.2.0...v2.0.0) (2020-05-08)


### ⚠ BREAKING CHANGES

* update to latest version of gts and typescript (#433)
* require node 10 in engines field (#431)

### Features

* require node 10 in engines field ([#431](https://github.com/googleapis/nodejs-compute/issues/431)) ([fe2897f](https://github.com/googleapis/nodejs-compute/commit/fe2897fd1d625df0ccf5b910ec850e761c2ed6d3))


### Bug Fixes

* apache license URL ([#468](https://github.com/googleapis/nodejs-compute/issues/468)) ([#427](https://github.com/googleapis/nodejs-compute/issues/427)) ([02d63ed](https://github.com/googleapis/nodejs-compute/commit/02d63ed5a5a3559be0b5e49ed4c771b3661518a1))
* **deps:** update dependency @google-cloud/common to v3 ([#421](https://github.com/googleapis/nodejs-compute/issues/421)) ([d4469b6](https://github.com/googleapis/nodejs-compute/commit/d4469b693745df5a8a36b6988b7dba98f7d55142))
* **deps:** update dependency @google-cloud/paginator to v3 ([#419](https://github.com/googleapis/nodejs-compute/issues/419)) ([e667aee](https://github.com/googleapis/nodejs-compute/commit/e667aeecf7b9f51875c06cb6a885040828dc1181))
* **deps:** update dependency @google-cloud/projectify to v2 ([#418](https://github.com/googleapis/nodejs-compute/issues/418)) ([b861540](https://github.com/googleapis/nodejs-compute/commit/b861540aa17118a7508c7c970d84864a9028f588))
* **deps:** update dependency @google-cloud/promisify to v2 ([#417](https://github.com/googleapis/nodejs-compute/issues/417)) ([eedce75](https://github.com/googleapis/nodejs-compute/commit/eedce75e0d3f10dfed8151f12150d38d032f6a27))
* **deps:** update dependency @sendgrid/mail to v7 ([#424](https://github.com/googleapis/nodejs-compute/issues/424)) ([17af0f4](https://github.com/googleapis/nodejs-compute/commit/17af0f425354b261f9afc8ab30e16e66b7193fec))


### Build System

* update to latest version of gts and typescript ([#433](https://github.com/googleapis/nodejs-compute/issues/433)) ([a4fa8cc](https://github.com/googleapis/nodejs-compute/commit/a4fa8cc21df7a894486832b05449fa7afc02b7ee))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
ace-n pushed a commit that referenced this pull request Nov 21, 2022
🤖 I have created a release \*beep\* \*boop\* 
---
## [2.0.0](https://github.com/googleapis/nodejs-compute/compare/v1.2.0...v2.0.0) (2020-05-08)


### ⚠ BREAKING CHANGES

* update to latest version of gts and typescript (#433)
* require node 10 in engines field (#431)

### Features

* require node 10 in engines field ([#431](https://github.com/googleapis/nodejs-compute/issues/431)) ([fe2897f](https://github.com/googleapis/nodejs-compute/commit/fe2897fd1d625df0ccf5b910ec850e761c2ed6d3))


### Bug Fixes

* apache license URL ([#468](https://github.com/googleapis/nodejs-compute/issues/468)) ([#427](https://github.com/googleapis/nodejs-compute/issues/427)) ([02d63ed](https://github.com/googleapis/nodejs-compute/commit/02d63ed5a5a3559be0b5e49ed4c771b3661518a1))
* **deps:** update dependency @google-cloud/common to v3 ([#421](https://github.com/googleapis/nodejs-compute/issues/421)) ([d4469b6](https://github.com/googleapis/nodejs-compute/commit/d4469b693745df5a8a36b6988b7dba98f7d55142))
* **deps:** update dependency @google-cloud/paginator to v3 ([#419](https://github.com/googleapis/nodejs-compute/issues/419)) ([e667aee](https://github.com/googleapis/nodejs-compute/commit/e667aeecf7b9f51875c06cb6a885040828dc1181))
* **deps:** update dependency @google-cloud/projectify to v2 ([#418](https://github.com/googleapis/nodejs-compute/issues/418)) ([b861540](https://github.com/googleapis/nodejs-compute/commit/b861540aa17118a7508c7c970d84864a9028f588))
* **deps:** update dependency @google-cloud/promisify to v2 ([#417](https://github.com/googleapis/nodejs-compute/issues/417)) ([eedce75](https://github.com/googleapis/nodejs-compute/commit/eedce75e0d3f10dfed8151f12150d38d032f6a27))
* **deps:** update dependency @sendgrid/mail to v7 ([#424](https://github.com/googleapis/nodejs-compute/issues/424)) ([17af0f4](https://github.com/googleapis/nodejs-compute/commit/17af0f425354b261f9afc8ab30e16e66b7193fec))


### Build System

* update to latest version of gts and typescript ([#433](https://github.com/googleapis/nodejs-compute/issues/433)) ([a4fa8cc](https://github.com/googleapis/nodejs-compute/commit/a4fa8cc21df7a894486832b05449fa7afc02b7ee))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants