Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add node sample for cloud composer tutorial #1708

Merged
merged 13 commits into from
Apr 16, 2020
Merged

feat: add node sample for cloud composer tutorial #1708

merged 13 commits into from
Apr 16, 2020

Conversation

sofisl
Copy link
Collaborator

@sofisl sofisl commented Apr 7, 2020

No description provided.

@sofisl sofisl requested review from fhinkel and leahecole April 7, 2020 01:13
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 7, 2020
leahecole
leahecole requested changes Apr 7, 2020
View reviewed changes
Copy link
Contributor

@leahecole leahecole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few meta questions/concerns:

  1. can we rename these files to be more descriptive? Something like composerDataflowTemplateOperatorJS? I know having dataflowtemplateoperator is super verbose, but it is descriptive.
  2. Your GH handle and mine should probably be added to the CODEOWNERS file
  3. we should add a README that links to the docs for this so that users who stumble across it on GH aren't super confused

composer/composerJSTutorial.js Outdated Show resolved Hide resolved
composer/test/composerJSTutorial.test.js Outdated Show resolved Hide resolved
@sofisl sofisl requested a review from leahecole April 7, 2020 22:35
@sofisl sofisl added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Apr 8, 2020
@kokoro-team kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 8, 2020
fhinkel
fhinkel reviewed Apr 9, 2020
View reviewed changes
composer/README.md Outdated Show resolved Hide resolved
leahecole
leahecole requested changes Apr 10, 2020
View reviewed changes
Copy link
Contributor

@leahecole leahecole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one nit about the codeowners, then whatever Franzi has to say and we're good :)

CODEOWNERS Outdated Show resolved Hide resolved
@sofisl sofisl added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Apr 10, 2020
@kokoro-team kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 10, 2020
@sofisl sofisl requested a review from leahecole April 15, 2020 17:33
This was referenced Nov 18, 2020
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leahecole leahecole leahecole approved these changes

@fhinkel fhinkel Awaiting requested review from fhinkel

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sofisl @leahecole @fhinkel @googlebot @kokoro-team