Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(lint): prefer const over var #1224

Merged
merged 2 commits into from
Mar 26, 2019
Merged

refactor(lint): prefer const over var #1224

merged 2 commits into from
Mar 26, 2019

Conversation

JustinBeckwith
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 25, 2019
@JustinBeckwith
Copy link
Contributor Author

@fhinkel I didn't do anything to dialogflow, and the failure appears to be infra related:

[08:58:43] Command done in 15 seconds
[08:58:46][ERROR] Failed to get build config
com.google.devtools.kokoro.config.ConfigException: Couldn't find build configuration under /tmp/workspace/workspace/cloud-devrel/nodejs-docs-samples/presubmit/functions/dialogflow/src/github/nodejs-docs-samples/.kokoro/functions.
	at com.google.devtools.kokoro.config.BuildConfigReader.lambda$read$2(BuildConfigReader.java:54)
	at java.util.Optional.orElseThrow(Optional.java:290)
	at com.google.devtools.kokoro.config.BuildConfigReader.read(BuildConfigReader.java:51)
	at com.google.devtools.kokoro.jenkins.plugin.kokorojob.store.NodeBuildConfigReader.invoke(NodeBuildConfigReader.java:39)
	at com.google.devtools.kokoro.jenkins.plugin.kokorojob.store.NodeBuildConfigReader.invoke(NodeBuildConfigReader.java:13)
	at hudson.FilePath$FileCallableWrapper.call(FilePath.java:2731)
	at hudson.remoting.UserRequest.perform(UserRequest.java:153)
	at hudson.remoting.UserRequest.perform(UserRequest.java:50)
	at hudson.remoting.Request$2.run(Request.java:336)

@fhinkel
Copy link
Contributor

fhinkel commented Mar 25, 2019

Dialogflow PR hasn't been merged so it fails on all other PRs

Copy link
Contributor

@fhinkel fhinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. I'd prefer we wait with more of these changes until release tests pass tonight.

Copy link
Contributor

@fhinkel fhinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change the fix command to npm run lint -- --fix? Doesn't really matter sind it's only one file.

@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 26, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 26, 2019
@fhinkel fhinkel merged commit 2482f90 into master Mar 26, 2019
@fhinkel fhinkel deleted the consty branch March 26, 2019 11:10
This was referenced Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants