translate: use unique gcs folders for batch translate tests #2053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
Fix: #2051 |
lesv
approved these changes
Feb 4, 2020
| @@ -137,7 +139,7 @@ public void testBatchTranslateTextWithGlossaryAndModel() | |||
| "en", | |||
| "ja", | |||
| INPUT_URI, | |||
| "gs://" + PROJECT_ID + "/BATCH_TRANSLATION_OUTPUT/", | |||
| "gs://" + PROJECT_ID + "/" + PREFIX_PATH, | |||
There was a problem hiding this comment.
Ok - but as I look at this, I wonder if String.format should be used as being a bit clearer, I've decided that it's just longer, but I wish we'd get rid of all the string contraction.
There was a problem hiding this comment.
Updated to use a variable.
private static final String OUTPUT_URI =
String.format("gs://%s/%s/%s/", PROJECT_ID, PREFIX, UUID.randomUUID());
lesv
approved these changes
Feb 4, 2020
Shabirmean
pushed a commit
that referenced
this pull request
Nov 17, 2022
…2053) * translate: use unique gcs folders for batch translate tests * update based on feedback * fix typo
9 tasks
Shabirmean
pushed a commit
that referenced
this pull request
Nov 18, 2022
…2053) * translate: use unique gcs folders for batch translate tests * update based on feedback * fix typo
9 tasks
Shabirmean
pushed a commit
that referenced
this pull request
Nov 18, 2022
…2053) * translate: use unique gcs folders for batch translate tests * update based on feedback * fix typo
anguillanneuf
pushed a commit
that referenced
this pull request
Dec 5, 2022
…2053) * translate: use unique gcs folders for batch translate tests * update based on feedback * fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.