WebSockets samples for Java #1022
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
lesv
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
lesv
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
lesv
suggested changes
Feb 12, 2018
lesv
suggested changes
Feb 12, 2018
| <artifactId>websocket</artifactId> | ||
| <packaging>war</packaging> | ||
|
|
||
| <parent> |
There was a problem hiding this comment.
This parent should be:
<!--
The parent pom defines common style checks and testing strategies for our samples.
Removing or replacing it should not affect the execution of the samples in anyway.
-->
<parent>
<groupId>com.google.cloud.samples</groupId>
<artifactId>shared-configuration</artifactId>
<version>1.0.8</version>
</parent>
|
ping |
|
Ping again |
|
Closing this as this needs to be re-done and re-tested. The team will re-submit this later. Thanks! |
Sita04
pushed a commit
that referenced
this pull request
Feb 7, 2023
🤖 I have created a release *beep* *boop* --- ## [3.7.4](https://github.com/googleapis/java-dlp/compare/v3.7.3...v3.7.4) (2022-10-03) ### Dependencies * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.4 ([#1021](https://github.com/googleapis/java-dlp/issues/1021)) ([dc6c270](https://github.com/googleapis/java-dlp/commit/dc6c2704358015046b86c193b4b3373f26648855)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding doc samples for WebSocket and session affinity support beta release.