Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time passed to startTimeOfDay must be UTC #113

Closed
almegeddon opened this issue Mar 16, 2016 · 3 comments
Closed

Time passed to startTimeOfDay must be UTC #113

almegeddon opened this issue Mar 16, 2016 · 3 comments
Assignees
Labels
🚨 This issue needs some love. triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@almegeddon
Copy link

Sample code from AwsRequester.java inaccurately prescribes Pacific Date/Time values here:

/**
 * Specify times below using US Pacific Time Zone.
 */
private static final String START_DATE = "YYYY-MM-DD";
private static final String START_TIME = "HH:MM:SS";

This bit us when setting up a transfer job recently. Browsing the Schedule source you can see UTC should be passed:

/**
 * The time in UTC at which the transfer will be scheduled to start in a day. Transfers may start
 * later than this time. If not specified, transfers are scheduled to start at midnight UTC.
 * @param startTimeOfDay startTimeOfDay or {@code null} for none
 */
public Schedule setStartTimeOfDay(TimeOfDay startTimeOfDay)
@tswast
Copy link
Contributor

tswast commented Mar 16, 2016

Thank you for your feedback. I'll look into this.

You are referring to the Storage sample at java-docs-samples/storage/storage-transfer/src/main/java/com/google/cloud/storage/storagetransfer/samples/AwsRequester.java correct?

@tswast tswast self-assigned this Mar 16, 2016
@almegeddon
Copy link
Author

Yes, you are correct. I mistakenly left out the full package in my original issue.

@lesv lesv added the type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. label Jul 28, 2016
@tswast
Copy link
Contributor

tswast commented Aug 18, 2016

Thanks again for the report. I fix this with #311

(Sorry it took 6 months, yikes!)

@yoshi-automation yoshi-automation added 🚨 This issue needs some love. triage me I really want to be triaged. labels Apr 6, 2020
minherz pushed a commit that referenced this issue Nov 9, 2022
🤖 I have created a release \*beep\* \*boop\* 
---
## [0.120.0](https://github.com/googleapis/java-errorreporting/compare/v0.119.2...v0.120.0) (2020-06-22)


### Features

* **deps:** adopt flatten plugin and google-cloud-shared-dependencies ([#175](https://github.com/googleapis/java-errorreporting/issues/175)) ([7ca8b66](https://github.com/googleapis/java-errorreporting/commit/7ca8b66b01b2d5f9009a62a1a7be7e055a32ede6))


### Bug Fixes

* restore GAPIC v2 retry configs ([#143](https://github.com/googleapis/java-errorreporting/issues/143)) ([fc9837e](https://github.com/googleapis/java-errorreporting/commit/fc9837e073c9f48e8e35b9a5ab15cc4188e60982))


### Dependencies

* update dependency com.google.api:api-common to v1.9.1 ([#149](https://github.com/googleapis/java-errorreporting/issues/149)) ([438aad7](https://github.com/googleapis/java-errorreporting/commit/438aad7173bc0012823339ac81f272f9b99ab209))
* update dependency com.google.api:api-common to v1.9.2 ([#156](https://github.com/googleapis/java-errorreporting/issues/156)) ([5a537fa](https://github.com/googleapis/java-errorreporting/commit/5a537fa3a8223ab4445598c0eeb42ac2a0f15389))
* update dependency com.google.api.grpc:proto-google-common-protos to v1.18.0 ([#137](https://github.com/googleapis/java-errorreporting/issues/137)) ([7278629](https://github.com/googleapis/java-errorreporting/commit/7278629514fe46c820c88f6b20dd8f533dd8d296))
* update dependency com.google.cloud:google-cloud-core to v1.93.5 ([#150](https://github.com/googleapis/java-errorreporting/issues/150)) ([ad3af0e](https://github.com/googleapis/java-errorreporting/commit/ad3af0e085f8917a19c32f67728837897e387e12))
* update dependency com.google.guava:guava-bom to v29 ([#113](https://github.com/googleapis/java-errorreporting/issues/113)) ([12b9e4f](https://github.com/googleapis/java-errorreporting/commit/12b9e4f21e80de984e88c8f87e38f705225b9b2a))
* update dependency com.google.protobuf:protobuf-java to v3.12.0 ([#141](https://github.com/googleapis/java-errorreporting/issues/141)) ([f92537d](https://github.com/googleapis/java-errorreporting/commit/f92537d97b57be7eb897b717fb488c52641c1f83))
* update dependency com.google.protobuf:protobuf-java to v3.12.2 ([#147](https://github.com/googleapis/java-errorreporting/issues/147)) ([2aa5cd1](https://github.com/googleapis/java-errorreporting/commit/2aa5cd1e995721146204825ad7b2743e6107affd))
* update dependency io.grpc:grpc-bom to v1.29.0 ([#128](https://github.com/googleapis/java-errorreporting/issues/128)) ([00f5a8c](https://github.com/googleapis/java-errorreporting/commit/00f5a8cc86814cbe3626daf4cb28c74933f778f5))
* update dependency io.grpc:grpc-bom to v1.30.0 ([#161](https://github.com/googleapis/java-errorreporting/issues/161)) ([917227f](https://github.com/googleapis/java-errorreporting/commit/917227f8d35e899134dc5999f08e9b5ebe27a804))
* update dependency org.threeten:threetenbp to v1.4.4 ([#133](https://github.com/googleapis/java-errorreporting/issues/133)) ([77ba87d](https://github.com/googleapis/java-errorreporting/commit/77ba87db15f7f2428e6a06a612d0886539af1d4c))


### Documentation

* fix several broken links in the docs. ([#157](https://github.com/googleapis/java-errorreporting/issues/157)) ([9606c51](https://github.com/googleapis/java-errorreporting/commit/9606c5160319e86c0b49ce573a30e2b3b95fb656))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
minherz pushed a commit that referenced this issue Nov 10, 2022
🤖 I have created a release \*beep\* \*boop\* 
---
## [0.120.0](https://github.com/googleapis/java-errorreporting/compare/v0.119.2...v0.120.0) (2020-06-22)


### Features

* **deps:** adopt flatten plugin and google-cloud-shared-dependencies ([#175](https://github.com/googleapis/java-errorreporting/issues/175)) ([7ca8b66](https://github.com/googleapis/java-errorreporting/commit/7ca8b66b01b2d5f9009a62a1a7be7e055a32ede6))


### Bug Fixes

* restore GAPIC v2 retry configs ([#143](https://github.com/googleapis/java-errorreporting/issues/143)) ([fc9837e](https://github.com/googleapis/java-errorreporting/commit/fc9837e073c9f48e8e35b9a5ab15cc4188e60982))


### Dependencies

* update dependency com.google.api:api-common to v1.9.1 ([#149](https://github.com/googleapis/java-errorreporting/issues/149)) ([438aad7](https://github.com/googleapis/java-errorreporting/commit/438aad7173bc0012823339ac81f272f9b99ab209))
* update dependency com.google.api:api-common to v1.9.2 ([#156](https://github.com/googleapis/java-errorreporting/issues/156)) ([5a537fa](https://github.com/googleapis/java-errorreporting/commit/5a537fa3a8223ab4445598c0eeb42ac2a0f15389))
* update dependency com.google.api.grpc:proto-google-common-protos to v1.18.0 ([#137](https://github.com/googleapis/java-errorreporting/issues/137)) ([7278629](https://github.com/googleapis/java-errorreporting/commit/7278629514fe46c820c88f6b20dd8f533dd8d296))
* update dependency com.google.cloud:google-cloud-core to v1.93.5 ([#150](https://github.com/googleapis/java-errorreporting/issues/150)) ([ad3af0e](https://github.com/googleapis/java-errorreporting/commit/ad3af0e085f8917a19c32f67728837897e387e12))
* update dependency com.google.guava:guava-bom to v29 ([#113](https://github.com/googleapis/java-errorreporting/issues/113)) ([12b9e4f](https://github.com/googleapis/java-errorreporting/commit/12b9e4f21e80de984e88c8f87e38f705225b9b2a))
* update dependency com.google.protobuf:protobuf-java to v3.12.0 ([#141](https://github.com/googleapis/java-errorreporting/issues/141)) ([f92537d](https://github.com/googleapis/java-errorreporting/commit/f92537d97b57be7eb897b717fb488c52641c1f83))
* update dependency com.google.protobuf:protobuf-java to v3.12.2 ([#147](https://github.com/googleapis/java-errorreporting/issues/147)) ([2aa5cd1](https://github.com/googleapis/java-errorreporting/commit/2aa5cd1e995721146204825ad7b2743e6107affd))
* update dependency io.grpc:grpc-bom to v1.29.0 ([#128](https://github.com/googleapis/java-errorreporting/issues/128)) ([00f5a8c](https://github.com/googleapis/java-errorreporting/commit/00f5a8cc86814cbe3626daf4cb28c74933f778f5))
* update dependency io.grpc:grpc-bom to v1.30.0 ([#161](https://github.com/googleapis/java-errorreporting/issues/161)) ([917227f](https://github.com/googleapis/java-errorreporting/commit/917227f8d35e899134dc5999f08e9b5ebe27a804))
* update dependency org.threeten:threetenbp to v1.4.4 ([#133](https://github.com/googleapis/java-errorreporting/issues/133)) ([77ba87d](https://github.com/googleapis/java-errorreporting/commit/77ba87db15f7f2428e6a06a612d0886539af1d4c))


### Documentation

* fix several broken links in the docs. ([#157](https://github.com/googleapis/java-errorreporting/issues/157)) ([9606c51](https://github.com/googleapis/java-errorreporting/commit/9606c5160319e86c0b49ce573a30e2b3b95fb656))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
minherz pushed a commit that referenced this issue Nov 10, 2022
🤖 I have created a release \*beep\* \*boop\* 
---
## [0.120.0](https://github.com/googleapis/java-errorreporting/compare/v0.119.2...v0.120.0) (2020-06-22)


### Features

* **deps:** adopt flatten plugin and google-cloud-shared-dependencies ([#175](https://github.com/googleapis/java-errorreporting/issues/175)) ([7ca8b66](https://github.com/googleapis/java-errorreporting/commit/7ca8b66b01b2d5f9009a62a1a7be7e055a32ede6))


### Bug Fixes

* restore GAPIC v2 retry configs ([#143](https://github.com/googleapis/java-errorreporting/issues/143)) ([fc9837e](https://github.com/googleapis/java-errorreporting/commit/fc9837e073c9f48e8e35b9a5ab15cc4188e60982))


### Dependencies

* update dependency com.google.api:api-common to v1.9.1 ([#149](https://github.com/googleapis/java-errorreporting/issues/149)) ([438aad7](https://github.com/googleapis/java-errorreporting/commit/438aad7173bc0012823339ac81f272f9b99ab209))
* update dependency com.google.api:api-common to v1.9.2 ([#156](https://github.com/googleapis/java-errorreporting/issues/156)) ([5a537fa](https://github.com/googleapis/java-errorreporting/commit/5a537fa3a8223ab4445598c0eeb42ac2a0f15389))
* update dependency com.google.api.grpc:proto-google-common-protos to v1.18.0 ([#137](https://github.com/googleapis/java-errorreporting/issues/137)) ([7278629](https://github.com/googleapis/java-errorreporting/commit/7278629514fe46c820c88f6b20dd8f533dd8d296))
* update dependency com.google.cloud:google-cloud-core to v1.93.5 ([#150](https://github.com/googleapis/java-errorreporting/issues/150)) ([ad3af0e](https://github.com/googleapis/java-errorreporting/commit/ad3af0e085f8917a19c32f67728837897e387e12))
* update dependency com.google.guava:guava-bom to v29 ([#113](https://github.com/googleapis/java-errorreporting/issues/113)) ([12b9e4f](https://github.com/googleapis/java-errorreporting/commit/12b9e4f21e80de984e88c8f87e38f705225b9b2a))
* update dependency com.google.protobuf:protobuf-java to v3.12.0 ([#141](https://github.com/googleapis/java-errorreporting/issues/141)) ([f92537d](https://github.com/googleapis/java-errorreporting/commit/f92537d97b57be7eb897b717fb488c52641c1f83))
* update dependency com.google.protobuf:protobuf-java to v3.12.2 ([#147](https://github.com/googleapis/java-errorreporting/issues/147)) ([2aa5cd1](https://github.com/googleapis/java-errorreporting/commit/2aa5cd1e995721146204825ad7b2743e6107affd))
* update dependency io.grpc:grpc-bom to v1.29.0 ([#128](https://github.com/googleapis/java-errorreporting/issues/128)) ([00f5a8c](https://github.com/googleapis/java-errorreporting/commit/00f5a8cc86814cbe3626daf4cb28c74933f778f5))
* update dependency io.grpc:grpc-bom to v1.30.0 ([#161](https://github.com/googleapis/java-errorreporting/issues/161)) ([917227f](https://github.com/googleapis/java-errorreporting/commit/917227f8d35e899134dc5999f08e9b5ebe27a804))
* update dependency org.threeten:threetenbp to v1.4.4 ([#133](https://github.com/googleapis/java-errorreporting/issues/133)) ([77ba87d](https://github.com/googleapis/java-errorreporting/commit/77ba87db15f7f2428e6a06a612d0886539af1d4c))


### Documentation

* fix several broken links in the docs. ([#157](https://github.com/googleapis/java-errorreporting/issues/157)) ([9606c51](https://github.com/googleapis/java-errorreporting/commit/9606c5160319e86c0b49ce573a30e2b3b95fb656))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sita04 pushed a commit that referenced this issue Nov 11, 2022
…uration to v1.0.16 (#113)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [com.google.cloud.samples:shared-configuration](https://github.com/GoogleCloudPlatform/java-repo-tools) | patch | `1.0.15` -> `1.0.16` |

---

### Release Notes

<details>
<summary>GoogleCloudPlatform/java-repo-tools</summary>

### [`v1.0.16`](https://github.com/GoogleCloudPlatform/java-repo-tools/releases/v1.0.16)

[Compare Source](https://github.com/GoogleCloudPlatform/java-repo-tools/compare/v1.0.15...v1.0.16)

Add a few SpotBugs exclusions:

-   `RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE` - existing - codegen bug
-   `UPM_UNCALLED_PRIVATE_METHOD` - probably SpotBug issue
-   `NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE` - likely SpotBug issue
-   `CLI_CONSTANT_LIST_INDEX` - style issue particular to our samples
-   `OBL_UNSATISFIED_OBLIGATION` - issue for SQL clients

</details>

---

### Renovate configuration

:date: **Schedule**: At any time (no schedule defined).

:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

:recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/java-recaptchaenterprise).
Sita04 pushed a commit that referenced this issue Nov 15, 2022
…uration to v1.0.16 (#113)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [com.google.cloud.samples:shared-configuration](https://github.com/GoogleCloudPlatform/java-repo-tools) | patch | `1.0.15` -> `1.0.16` |

---

### Release Notes

<details>
<summary>GoogleCloudPlatform/java-repo-tools</summary>

### [`v1.0.16`](https://github.com/GoogleCloudPlatform/java-repo-tools/releases/v1.0.16)

[Compare Source](https://github.com/GoogleCloudPlatform/java-repo-tools/compare/v1.0.15...v1.0.16)

Add a few SpotBugs exclusions:

-   `RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE` - existing - codegen bug
-   `UPM_UNCALLED_PRIVATE_METHOD` - probably SpotBug issue
-   `NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE` - likely SpotBug issue
-   `CLI_CONSTANT_LIST_INDEX` - style issue particular to our samples
-   `OBL_UNSATISFIED_OBLIGATION` - issue for SQL clients

</details>

---

### Renovate configuration

:date: **Schedule**: At any time (no schedule defined).

:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

:recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/java-recaptchaenterprise).
Shabirmean pushed a commit that referenced this issue Nov 15, 2022
…113)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [com.google.cloud:libraries-bom](https://github.com/GoogleCloudPlatform/cloud-opensource-java) | major | `5.7.0` -> `6.0.0` |

---

### Renovate configuration

:date: **Schedule**: At any time (no schedule defined).

:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

:recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/java-document-ai).
Shabirmean pushed a commit that referenced this issue Nov 15, 2022
…113)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [com.google.cloud:libraries-bom](https://github.com/GoogleCloudPlatform/cloud-opensource-java) | major | `5.7.0` -> `6.0.0` |

---

### Renovate configuration

:date: **Schedule**: At any time (no schedule defined).

:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

:recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/java-document-ai).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 This issue needs some love. triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

4 participants