Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .codecov.yml to use the PRs base as reference #1934

Merged
merged 1 commit into from
May 20, 2024

Conversation

kislaykishore
Copy link
Collaborator

Currently codecov uses master as the reference which doesn't really portray the right picture since the changes in master since the feature branch was cut off can lead to unrelated code coverage changes showing up.

Description

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

Currently codecov uses master as the reference which doesn't really portray the right picture since the changes in master since the feature branch was cut off can lead to unrelated code coverage changes showing up.
@kislaykishore kislaykishore requested a review from a team as a code owner May 20, 2024 10:09
Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.29%. Comparing base (820d793) to head (603caff).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1934      +/-   ##
==========================================
- Coverage   61.30%   61.29%   -0.02%     
==========================================
  Files         129      129              
  Lines       12339    12339              
==========================================
- Hits         7565     7563       -2     
- Misses       4434     4436       +2     
  Partials      340      340              
Flag Coverage Δ
unittests 61.29% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kislaykishore kislaykishore merged commit 579f839 into master May 20, 2024
12 of 13 checks passed
@kislaykishore kislaykishore deleted the kislaykishore-patch-2 branch May 20, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants