Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Cobra root command. #1908

Merged
merged 1 commit into from
May 21, 2024
Merged

Add a Cobra root command. #1908

merged 1 commit into from
May 21, 2024

Conversation

kislaykishore
Copy link
Collaborator

  • This is to ease the migration from urfave/cli to Cobra + Viper for configuration.
  • The new config will only be triggered if ENABLE_VIPER_CONFIG env var is set to true.

Description

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

@kislaykishore kislaykishore requested a review from a team as a code owner May 14, 2024 04:52
ashmeenkaur
ashmeenkaur previously approved these changes May 21, 2024
Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 9.09091% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 61.22%. Comparing base (579f839) to head (110d9ac).
Report is 2 commits behind head on master.

Files Patch % Lines
cmd/root.go 12.50% 7 Missing ⚠️
main.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1908      +/-   ##
==========================================
- Coverage   61.30%   61.22%   -0.09%     
==========================================
  Files         129      130       +1     
  Lines       12339    12350      +11     
==========================================
- Hits         7565     7561       -4     
- Misses       4434     4448      +14     
- Partials      340      341       +1     
Flag Coverage Δ
unittests 61.22% <9.09%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ashmeenkaur
ashmeenkaur previously approved these changes May 21, 2024
main.go Outdated Show resolved Hide resolved
* This is to ease the migration from urfave/cli to Cobra + Viper for
  configuration.
* The new config will only be triggered if ENABLE_VIPER_CONFIG env var
  is set to true.
Copy link
Collaborator

@raj-prince raj-prince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linux tests are failing, please check before merge.

@kislaykishore kislaykishore merged commit d824d73 into master May 21, 2024
12 of 13 checks passed
@kislaykishore kislaykishore deleted the add-cobra branch May 21, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants