-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PR3] E2E tests for parallel dirops #1907
Conversation
460163b
to
cc92deb
Compare
18f4ecd
to
e909bab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for integration test changes
95fbfa3
to
4ada573
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1907 +/- ##
==========================================
- Coverage 61.30% 60.94% -0.37%
==========================================
Files 129 130 +1
Lines 12339 12424 +85
==========================================
+ Hits 7565 7572 +7
- Misses 4434 4512 +78
Partials 340 340
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
4ada573
to
8d3c054
Compare
8d3c054
to
404b8f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, a couple of nits.
Description
E2E tests for parallel dirops
Link to the issue in case of a bug fix.
NA
Testing details