Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initializing new storage control client #1865

Merged
merged 32 commits into from
May 8, 2024
Merged

Conversation

Tulsishah
Copy link
Collaborator

@Tulsishah Tulsishah commented Apr 26, 2024

Description

When the enable-hns flag is turned on, a new storage control client is initialized for GRPC protocol connections to utilize the new control client APIs. Retry logic, similar to that used for the storage client, has been added.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - Added
  3. Integration tests - Automated.

@Tulsishah Tulsishah added the execute-integration-tests Run only integration tests label Apr 26, 2024
@Tulsishah Tulsishah changed the title Storage control client Initializing new storage control client incase of GRPC protocol. Apr 26, 2024
@Tulsishah Tulsishah changed the title Initializing new storage control client incase of GRPC protocol. Initializing new storage control client incase of GRPC protocol Apr 26, 2024
@Tulsishah Tulsishah marked this pull request as ready for review April 28, 2024 04:55
@Tulsishah Tulsishah requested a review from a team as a code owner April 28, 2024 04:55
@Tulsishah Tulsishah changed the title Initializing new storage control client incase of GRPC protocol Initializing new storage control client Apr 29, 2024
@Tulsishah Tulsishah requested a review from sethiay April 29, 2024 10:09
Copy link
Collaborator

@ankitaluthra1 ankitaluthra1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NA

go.mod Outdated Show resolved Hide resolved
internal/storage/storage_handle.go Outdated Show resolved Hide resolved
internal/storage/storage_handle.go Outdated Show resolved Hide resolved
internal/storage/storage_handle.go Show resolved Hide resolved
internal/storage/storage_handle.go Show resolved Hide resolved
internal/storage/storage_handle.go Show resolved Hide resolved
main.go Show resolved Hide resolved
ankitaluthra1
ankitaluthra1 previously approved these changes May 8, 2024
@Tulsishah Tulsishah requested a review from raj-prince May 8, 2024 10:22
@Tulsishah Tulsishah merged commit 4620898 into master May 8, 2024
8 checks passed
@Tulsishah Tulsishah deleted the storage_control_client branch July 19, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants