Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR-2][Phase1 Implementation] Ignore GCSFuse interrupts #1860

Merged
merged 16 commits into from
May 2, 2024

Conversation

ashmeenkaur
Copy link
Collaborator

@ashmeenkaur ashmeenkaur commented Apr 23, 2024

Description

This PR is phase 1 implementation for ignoring GCSFuse interrupts. This change will allow operations like git clone on GCSFuse mounted directory.

The changes are behind ignore-interrupts with default value false. In phase-2 implementation, we will ignore interrupts by default.

This workaround will potentially solve the following open issues:
#1016, #288, #562, #321

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - Manually verified that git clone works
  2. Unit tests - Added
  3. Integration tests - Added and ran via KOKORO

@ashmeenkaur ashmeenkaur changed the base branch from master to add_flag_to_ignore_interrupts April 24, 2024 10:48
@ashmeenkaur ashmeenkaur changed the title [Phase1 Implementation] Ignore GCSFuse interrupts [PR-2][Phase1 Implementation] Ignore GCSFuse interrupts Apr 24, 2024
@ashmeenkaur ashmeenkaur added the execute-integration-tests Run only integration tests label Apr 24, 2024
@ashmeenkaur ashmeenkaur marked this pull request as ready for review April 24, 2024 11:13
@ashmeenkaur ashmeenkaur requested a review from a team as a code owner April 24, 2024 11:13
@ashmeenkaur ashmeenkaur requested review from sethiay and removed request for a team April 24, 2024 11:13
internal/fs/fs.go Outdated Show resolved Hide resolved
internal/fs/fs.go Outdated Show resolved Hide resolved
tools/integration_tests/interrupt/git_clone_test.go Outdated Show resolved Hide resolved
@ashmeenkaur ashmeenkaur force-pushed the add_flag_to_ignore_interrupts branch from 2c3a6c0 to 50f023a Compare April 25, 2024 10:56
Base automatically changed from add_flag_to_ignore_interrupts to master April 26, 2024 11:06
internal/fs/fs.go Outdated Show resolved Hide resolved
internal/fs/interrupt_test.go Outdated Show resolved Hide resolved
internal/fs/interrupt_test.go Outdated Show resolved Hide resolved
internal/fs/interrupt_test.go Outdated Show resolved Hide resolved
tools/integration_tests/interrupt/interrupt_test.go Outdated Show resolved Hide resolved
@ashmeenkaur ashmeenkaur merged commit 4499126 into master May 2, 2024
8 checks passed
@ashmeenkaur ashmeenkaur deleted the phase1_interrupt_issue branch May 2, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-integration-tests Run only integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants