Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing new flag to enable hns flow #1855

Merged
merged 8 commits into from
Apr 25, 2024
Merged

Conversation

Tulsishah
Copy link
Collaborator

@Tulsishah Tulsishah commented Apr 22, 2024

Description

A new flag, --enable-hns, has been introduced to enable the HNS flow when creating the storage control client for gRPC. The flag's default value is false, and it can be enabled by setting it to true.
config file structure.

enable-hns: true

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - Tested manually
  2. Unit tests - NA
  3. Integration tests - Automated

@Tulsishah Tulsishah added the execute-integration-tests Run only integration tests label Apr 22, 2024
@Tulsishah Tulsishah marked this pull request as ready for review April 22, 2024 09:26
@Tulsishah Tulsishah requested a review from a team as a code owner April 22, 2024 09:26
internal/config/testdata/valid_config.yaml Outdated Show resolved Hide resolved
main_test.go Show resolved Hide resolved
internal/config/mount_config.go Outdated Show resolved Hide resolved
@Tulsishah Tulsishah requested a review from sethiay April 23, 2024 16:21
@Tulsishah Tulsishah removed the request for review from raj-prince April 25, 2024 05:46
@Tulsishah Tulsishah merged commit 40652e3 into master Apr 25, 2024
8 checks passed
@Tulsishah Tulsishah deleted the introducing_new_hns_flag branch July 19, 2024 12:18
@Tulsishah Tulsishah added hns-integration and removed execute-integration-tests Run only integration tests labels Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants