Skip to content

Commit

Permalink
review comment
Browse files Browse the repository at this point in the history
  • Loading branch information
Tulsishah committed Apr 30, 2024
1 parent 394b0e4 commit 9df06df
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion internal/storage/storage_handle.go
Original file line number Diff line number Diff line change
Expand Up @@ -176,12 +176,14 @@ func NewStorageHandle(ctx context.Context, clientConfig storageutil.StorageClien
return
}

// TODO: Verify that clientConfig controls the client protocol even when HTTP is available.
if clientConfig.EnableHNS {
controlClient, err = createGRPCControlClientHandle(ctx, &clientConfig)
if err != nil {
err = fmt.Errorf("StorageControl Client: %w", err)
err = fmt.Errorf("Could not create StorageControl Client: %w", err)
}
}

// ShouldRetry function checks if an operation should be retried based on the
// response of operation (error.Code).
// RetryAlways causes all operations to be checked for retries using
Expand Down

0 comments on commit 9df06df

Please sign in to comment.