Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/add bp test doc: adds the first draft of the user guide for the test framework #983

Merged
merged 5 commits into from
Sep 9, 2021
Merged

Conversation

g-awmalik
Copy link
Collaborator

A few links need to be updated that are dependent on PR: 245

@g-awmalik
Copy link
Collaborator Author

/gcbrun

@g-awmalik
Copy link
Collaborator Author

/assign @bharathkkb

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@morgante this reads more as guide (KRM will also be added here in the future) rather than a framework readme, should we consider a lighter readme linking to this guide?

infra/blueprint-test/README.md Outdated Show resolved Hide resolved
infra/blueprint-test/README.md Outdated Show resolved Hide resolved
infra/blueprint-test/README.md Outdated Show resolved Hide resolved
infra/blueprint-test/README.md Outdated Show resolved Hide resolved
infra/blueprint-test/README.md Outdated Show resolved Hide resolved
infra/blueprint-test/README.md Outdated Show resolved Hide resolved
infra/blueprint-test/README.md Outdated Show resolved Hide resolved
@morgante
Copy link
Contributor

morgante commented Sep 7, 2021

@morgante this reads more as guide (KRM will also be added here in the future) rather than a framework readme, should we consider a lighter readme linking to this guide?

I think this is fine as is for now. If we want a shorter README later, we can add that later.

@g-awmalik
Copy link
Collaborator Author

@bharathkkb - please take another look

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM

infra/blueprint-test/README.md Outdated Show resolved Hide resolved
infra/blueprint-test/README.md Outdated Show resolved Hide resolved
infra/blueprint-test/README.md Outdated Show resolved Hide resolved
infra/blueprint-test/README.md Outdated Show resolved Hide resolved
infra/blueprint-test/README.md Show resolved Hide resolved
infra/blueprint-test/README.md Outdated Show resolved Hide resolved
infra/blueprint-test/README.md Show resolved Hide resolved
infra/blueprint-test/README.md Outdated Show resolved Hide resolved
infra/blueprint-test/README.md Outdated Show resolved Hide resolved
infra/blueprint-test/README.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants