This repository has been archived by the owner on Nov 11, 2022. It is now read-only.
Increase KafkaIO version to 0.2.0 #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent PR GoogleCloudPlatform#491 changes how KafkaIO splits. This makes it incompatible with Dataflow update across these two versions.
|
+R: @dhalperi |
|
Suggest creating a README.md |
dhalperi
suggested changes
Jan 6, 2017
|
Added README.md. |
dhalperi
suggested changes
Jan 9, 2017
| ```java | ||
| PCollection<KV<Long, String>> kafkaRecords = | ||
| pipeline | ||
| .applY(KafkaIO.read() |
| .withBootstrapServers("broker_1:9092,broker_2:9092") | ||
| .withTopic("results") | ||
| .withKeyCoder(BigEndianLongCoder.of()) | ||
| .withValueCoder(StringUtf8Coder.of()) |
| # KafkaIO : Dataflow Unbounded Source and Sink for Kafka Topics | ||
|
|
||
| KafkaIO provides unbounded sources and sinks for [Kafka](https://www.firebase.com/) | ||
| topics. Kafka version 0.9 and above are supported. |
There was a problem hiding this comment.
is this correct, or are code changes needed to support Kafka 0.10 or 0.11?
There was a problem hiding this comment.
Works with 0.10, but haven't tested with 0.11 (kafka master?). We can remove the line or mention specific versions tested.
|
+R: @dhalperi . I had addressed the comments immediately. I am not sure how to mark 'Changes Requested' as 'Done'. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent PR #491 changes how KafkaIO splits. This makes it incompatible
with Dataflow update across these two versions.