Add documentUrl option
#12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
|
I signed it! |
|
CLAs look good, thanks! |
|
@developit any updates? |
|
Hiya! Sorry about that - this looks great! |
developit
reviewed
Aug 29, 2018
src/index.js
Outdated
| @@ -156,6 +156,10 @@ async function prerender (parentCompilation, request, options, inject, loader) { | |||
| // suppress console-proxied eval() errors, but keep console proxying | |||
| virtualConsole: new jsdom.VirtualConsole({ omitJSDOMErrors: false }).sendTo(console), | |||
|
|
|||
| // `url` sets the value returned by `window.location`, `document.URL`... | |||
| // Useful for routers that depend on the current URL (such as react-router or reach-router) | |||
| url: options.documentUrl, | |||
There was a problem hiding this comment.
Could we fall back to a default of http://localhost here in order to fix #14?
There was a problem hiding this comment.
I currently don't have internet, will change it once I get it fixed. Thanks for the review 😀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some libraries such as
react-routerorreach-routerdepend on the current window URL (returned bywindow.location,location.URL...) to determine which route to render.This PR adds a
documentUrloption which is passed to the JSDOMurloption which has the following behavior according to their docs:urlsets the value returned by window.location, document.URL, and document.documentURI, and affects things like resolution of relative URLs within the document and the same-origin restrictions and referrer used while fetching subresources. It defaults to "about:blank".The default value is
undefinedwhich will tell JSDOM to use the defaultabout:blankwhich you cannot change inside the JSDOM instance.@developit