feat: support ESM module #2451
Merged
feat: support ESM module #2451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lightning00Blade
force-pushed
the
change-to-esm
branch
from
d44b853
to
752f1d5
Compare
Lightning00Blade
force-pushed
the
change-to-esm
branch
5 times, most recently
from
08ab685
to
31b2607
Compare
sadym-chromium
approved these changes
Sep 11, 2024
Lightning00Blade
force-pushed
the
change-to-esm
branch
from
31b2607
to
1c8b214
Compare
|
It looks like local e2e run is broken with this change |
sadym-chromium
added a commit
that referenced
this pull request
Sep 11, 2024
This reverts commit 662a857.
sadym-chromium
added a commit
that referenced
this pull request
Sep 11, 2024
This reverts commit 4962714.
Lightning00Blade
pushed a commit
that referenced
this pull request
Sep 16, 2024
🤖 I have created a release *beep* *boop* --- ## [0.7.1](chromium-bidi-v0.7.0...chromium-bidi-v0.7.1) (2024-09-16) ### Features * initial implementation for the Web Bluetooth spec ([#2060](#2060)) ([ecb18d3](ecb18d3)) * support ESM module ([#2451](#2451)) ([662a857](662a857)) * support network.setCacheBehavior ([#2593](#2593)) ([75ba46c](75ba46c)) * support only statusCode in continueResponse ([#2598](#2598)) ([1eeff5b](1eeff5b)) ### Bug Fixes * add bluetooth command parser and fix tests ([#2589](#2589)) ([98ad2d9](98ad2d9)) * clear the buffered logs when browsing context is destroyed ([#2592](#2592)) ([36fb707](36fb707)), closes [#475](#475) * provide invalid set cache props ([#2590](#2590)) ([0830f00](0830f00)) * **spec:** update WebBluetooth implementation to match the latest spec ([#2588](#2588)) ([ec1ab96](ec1ab96)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also makes the MapperTab use ESM rather then CommonJS which is smaller.