fix: provide invalid set cache props (#2590)

Provides the type checks for the command Ref: #2385 --------- Co-authored-by: browser-automation-bot <133232582+browser-automation-bot@users.noreply.github.com>
GoogleChromeLabs · Sep 5, 2024 · 0830f00 · 0830f00
1 parent 98ad2d9
commit 0830f00
Show file tree

Hide file tree

Showing 10 changed files with 29 additions and 155 deletions.
diff --git a/src/bidiMapper/BidiNoOpParser.ts b/src/bidiMapper/BidiNoOpParser.ts
@@ -184,6 +184,9 @@ export class BidiNoOpParser implements BidiCommandParameterParser {
   ): Network.RemoveInterceptParameters {
     return params as Network.RemoveInterceptParameters;
   }
+  parseSetCacheBehavior(params: unknown): Network.SetCacheBehaviorParameters {
+    return params as Network.SetCacheBehaviorParameters;
+  }
   // keep-sorted end
 
   // Permissions domain

diff --git a/src/bidiMapper/BidiParser.ts b/src/bidiMapper/BidiParser.ts
@@ -109,6 +109,7 @@ export interface BidiCommandParameterParser {
   parseRemoveInterceptParams(
     params: unknown
   ): Network.RemoveInterceptParameters;
+  parseSetCacheBehavior(params: unknown): Network.SetCacheBehaviorParameters;
   // keep-sorted end block=yes
 
   // Script domain

diff --git a/src/bidiMapper/CommandProcessor.ts b/src/bidiMapper/CommandProcessor.ts
@@ -279,8 +279,8 @@ export class CommandProcessor extends EventEmitter<CommandProcessorEventsMap> {
           this.#parser.parseRemoveInterceptParams(command.params)
         );
       case 'network.setCacheBehavior':
-        throw new UnknownErrorException(
-          "Method 'network.setCacheBehavior' is not implemented."
+        return await this.#networkProcessor.setCacheBehavior(
+          this.#parser.parseSetCacheBehavior(command.params)
         );
       // keep-sorted end
 

diff --git a/src/bidiMapper/modules/network/NetworkProcessor.ts b/src/bidiMapper/modules/network/NetworkProcessor.ts
@@ -20,6 +20,7 @@ import {
   type EmptyResult,
   NoSuchRequestException,
   InvalidArgumentException,
+  UnknownErrorException,
 } from '../../../protocol/protocol.js';
 import {URLPattern} from '../../../utils/UrlPattern.js';
 import type {BrowsingContextStorage} from '../context/BrowsingContextStorage.js';
@@ -188,6 +189,15 @@ export class NetworkProcessor {
     return {};
   }
 
+  // eslint-disable-next-line @typescript-eslint/require-await
+  async setCacheBehavior(
+    _params: Network.SetCacheBehaviorParameters
+  ): Promise<EmptyResult> {
+    throw new UnknownErrorException(
+      "Method 'network.setCacheBehavior' is not implemented."
+    );
+  }
+
   #getRequestOrFail(id: Network.Request): NetworkRequest {
     const request = this.#networkStorage.getRequestById(id);
     if (!request) {

diff --git a/src/bidiTab/BidiParser.ts b/src/bidiTab/BidiParser.ts
@@ -157,6 +157,9 @@ export class BidiParser implements BidiCommandParameterParser {
   ): Network.RemoveInterceptParameters {
     return Parser.Network.parseRemoveInterceptParameters(params);
   }
+  parseSetCacheBehavior(params: unknown): Network.SetCacheBehaviorParameters {
+    return Parser.Network.parseSetCacheBehavior(params);
+  }
   // keep-sorted end
 
   // Permissions domain

diff --git a/src/protocol-parser/protocol-parser.ts b/src/protocol-parser/protocol-parser.ts
@@ -112,6 +112,13 @@ export namespace Network {
       WebDriverBidi.Network.RemoveInterceptParametersSchema
     );
   }
+
+  export function parseSetCacheBehavior(params: unknown) {
+    return parseObject(
+      params,
+      WebDriverBidi.Network.SetCacheBehaviorParametersSchema
+    ) as Protocol.Network.SetCacheBehaviorParameters;
+  }
 }
 
 /** @see https://w3c.github.io/webdriver-bidi/#module-script */

diff --git a/.../headful/webdriver/tests/bidi/browsing_context/navigation_failed/navigation_failed.py.ini b/.../headful/webdriver/tests/bidi/browsing_context/navigation_failed/navigation_failed.py.ini
@@ -25,3 +25,6 @@
 
   [test_close_iframe]
     expected: FAIL
+
+  [test_with_new_navigation]
+    expected: [PASS, FAIL]
diff --git a/...adata/chromedriver/headful/webdriver/tests/bidi/network/set_cache_behavior/invalid.py.ini b/...adata/chromedriver/headful/webdriver/tests/bidi/network/set_cache_behavior/invalid.py.ini
@@ -1,54 +1,3 @@
 [invalid.py]
-  [test_params_cache_behavior_invalid_type[None\]]
-    expected: FAIL
-
-  [test_params_cache_behavior_invalid_type[False\]]
-    expected: FAIL
-
-  [test_params_cache_behavior_invalid_type[42\]]
-    expected: FAIL
-
-  [test_params_cache_behavior_invalid_type[value3\]]
-    expected: FAIL
-
-  [test_params_cache_behavior_invalid_type[value4\]]
-    expected: FAIL
-
-  [test_params_cache_behavior_invalid_value[bypas\]]
-    expected: FAIL
-
-  [test_params_cache_behavior_invalid_value[DEFAULT\]]
-    expected: FAIL
-
-  [test_params_contexts_invalid_type[foo\]]
-    expected: FAIL
-
-  [test_params_contexts_invalid_type[42\]]
-    expected: FAIL
-
-  [test_params_contexts_invalid_type[False\]]
-    expected: FAIL
-
-  [test_params_contexts_invalid_type[value3\]]
-    expected: FAIL
-
-  [test_params_contexts_invalid_value_empty_array]
-    expected: FAIL
-
-  [test_params_contexts_invalid_array_element_type[None\]]
-    expected: FAIL
-
-  [test_params_contexts_invalid_array_element_type[42\]]
-    expected: FAIL
-
-  [test_params_contexts_invalid_array_element_type[False\]]
-    expected: FAIL
-
-  [test_params_contexts_invalid_array_element_type[value3\]]
-    expected: FAIL
-
-  [test_params_contexts_invalid_array_element_type[value4\]]
-    expected: FAIL
-
   [test_params_contexts_invalid_array_element_value]
     expected: FAIL
diff --git a/...data/chromedriver/headless/webdriver/tests/bidi/network/set_cache_behavior/invalid.py.ini b/...data/chromedriver/headless/webdriver/tests/bidi/network/set_cache_behavior/invalid.py.ini
@@ -1,54 +1,3 @@
 [invalid.py]
-  [test_params_cache_behavior_invalid_type[None\]]
-    expected: FAIL
-
-  [test_params_cache_behavior_invalid_type[False\]]
-    expected: FAIL
-
-  [test_params_cache_behavior_invalid_type[42\]]
-    expected: FAIL
-
-  [test_params_cache_behavior_invalid_type[value3\]]
-    expected: FAIL
-
-  [test_params_cache_behavior_invalid_type[value4\]]
-    expected: FAIL
-
-  [test_params_cache_behavior_invalid_value[bypas\]]
-    expected: FAIL
-
-  [test_params_cache_behavior_invalid_value[DEFAULT\]]
-    expected: FAIL
-
-  [test_params_contexts_invalid_type[foo\]]
-    expected: FAIL
-
-  [test_params_contexts_invalid_type[42\]]
-    expected: FAIL
-
-  [test_params_contexts_invalid_type[False\]]
-    expected: FAIL
-
-  [test_params_contexts_invalid_type[value3\]]
-    expected: FAIL
-
-  [test_params_contexts_invalid_value_empty_array]
-    expected: FAIL
-
-  [test_params_contexts_invalid_array_element_type[None\]]
-    expected: FAIL
-
-  [test_params_contexts_invalid_array_element_type[42\]]
-    expected: FAIL
-
-  [test_params_contexts_invalid_array_element_type[False\]]
-    expected: FAIL
-
-  [test_params_contexts_invalid_array_element_type[value3\]]
-    expected: FAIL
-
-  [test_params_contexts_invalid_array_element_type[value4\]]
-    expected: FAIL
-
   [test_params_contexts_invalid_array_element_value]
     expected: FAIL
diff --git a/wpt-metadata/mapper/headless/webdriver/tests/bidi/network/set_cache_behavior/invalid.py.ini b/wpt-metadata/mapper/headless/webdriver/tests/bidi/network/set_cache_behavior/invalid.py.ini
@@ -1,54 +1,3 @@
 [invalid.py]
-  [test_params_cache_behavior_invalid_type[None\]]
-    expected: FAIL
-
-  [test_params_cache_behavior_invalid_type[False\]]
-    expected: FAIL
-
-  [test_params_cache_behavior_invalid_type[42\]]
-    expected: FAIL
-
-  [test_params_cache_behavior_invalid_type[value3\]]
-    expected: FAIL
-
-  [test_params_cache_behavior_invalid_type[value4\]]
-    expected: FAIL
-
-  [test_params_cache_behavior_invalid_value[bypas\]]
-    expected: FAIL
-
-  [test_params_cache_behavior_invalid_value[DEFAULT\]]
-    expected: FAIL
-
-  [test_params_contexts_invalid_type[foo\]]
-    expected: FAIL
-
-  [test_params_contexts_invalid_type[42\]]
-    expected: FAIL
-
-  [test_params_contexts_invalid_type[False\]]
-    expected: FAIL
-
-  [test_params_contexts_invalid_type[value3\]]
-    expected: FAIL
-
-  [test_params_contexts_invalid_value_empty_array]
-    expected: FAIL
-
-  [test_params_contexts_invalid_array_element_type[None\]]
-    expected: FAIL
-
-  [test_params_contexts_invalid_array_element_type[42\]]
-    expected: FAIL
-
-  [test_params_contexts_invalid_array_element_type[False\]]
-    expected: FAIL
-
-  [test_params_contexts_invalid_array_element_type[value3\]]
-    expected: FAIL
-
-  [test_params_contexts_invalid_array_element_type[value4\]]
-    expected: FAIL
-
   [test_params_contexts_invalid_array_element_value]
     expected: FAIL