test(smokehouse): fix tmp dir usage #9855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
requested review from
brendankenny and
patrickhulce
as code owners
brendankenny
approved these changes
Oct 17, 2019
| @@ -9,6 +9,7 @@ | |||
| /* eslint-disable no-console */ | |||
|
|
|||
| const fs = require('fs'); | |||
| const mkdirp = require('mkdirp'); | |||
There was a problem hiding this comment.
we really should have switched everything over to make-dir (or fs.mkdir after the move to node 10), but good for now
brendankenny
added a commit
that referenced
this pull request
Oct 17, 2019
14 tasks
brendankenny
added a commit
that referenced
this pull request
Oct 17, 2019
brendankenny
added a commit
that referenced
this pull request
Oct 21, 2019
brendankenny
added a commit
that referenced
this pull request
Oct 25, 2019
brendankenny
added a commit
that referenced
this pull request
Oct 25, 2019
brendankenny
added a commit
that referenced
this pull request
Oct 28, 2019
brendankenny
added a commit
that referenced
this pull request
Oct 30, 2019
brendankenny
added a commit
that referenced
this pull request
Nov 4, 2019
paulirish
pushed a commit
that referenced
this pull request
Nov 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you don't run LH in the root directory, this breaks.
Also, the
test.shrelease script doesn't have a.tmpfolder, so this breaks there too.I plan on following up later with a centralized place to make temporary files (we do this in a few different places).