Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(i18n): add 'meaning' to i18n README #9787

Merged
merged 2 commits into from
Oct 8, 2019
Merged

docs(i18n): add 'meaning' to i18n README #9787

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1b6ad4
docs(i18n): add mentions of meaning to i18n readme
exterkamp Oct 4, 2019
2757b0b
feedback
exterkamp Oct 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lighthouse-core/lib/i18n/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Terminology

* **CTC format**: The [Chrome extension & Chrome app i18n format](https://developer.chrome.com/extensions/i18n-messages). JSON with their specified model for declaring placeholders, examples, etc. Used as an interchange data format.
* **CTC format**: The [Chrome extension & Chrome app i18n format](https://developer.chrome.com/extensions/i18n-messages). JSON with their specified model for declaring placeholders, examples, etc. Used as an interchange data format. With some minor changes.
exterkamp marked this conversation as resolved.
Show resolved Hide resolved
* **LHL syntax** (Lighthouse Localizable syntax): The ICU-friendly string syntax that is used to author `UIStrings` and is seen in the locale files in `i18n/locales/*.json`. Lighthouse has a custom syntax these strings combines many ICU message features along with some markdown.
* **ICU**: ICU (International Components for Unicode) is a localization project and standard defined by the Unicode consortium. In general, we refer to "ICU" as the [ICU message formatting](http://userguide.icu-project.org/formatparse/messages) syntax.

Expand Down Expand Up @@ -202,6 +202,7 @@ CTC is a name that is distinct and identifies this as the Chrome translation for
"name": {
"message": "Message text, with optional placeholders.",
"description": "Translator-aimed description of the message.",
"meaning": "Description given when a message is duplicated, in order to give context to the message.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this just a copy of description for us? seems like this doc is a good place to diverge from the chrome docs if we're doing something different :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup. Just having a meaning in our spec is the divergence. Should there be more context for it?

"placeholders": {
"placeholder_name": {
"content": "A string to be placed within the message.",
Expand Down