Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: partial artifact update #8802
tests: partial artifact update #8802
Changes from all commits
bf03e77
f8d28ed
663d353
0b7935f
a91bbd9
7351fd5
e63b41c
4794a9f
293a714
67c174d
b56bc13
947a8a0
14076fd
84e6147
ec14726
b16af27
ca094bc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want to log a warning if
artifactName
isn't a key onnewArtifacts
oroldArtifacts
(need to check both in case it's adding a new one or removing an old one?)At worst an unknown key will just have no effect and we don't want to throw because it'll leave things in a bad state, but it might be good to let the user know they spelled something wrong or whatever
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will throw now if it can't find the artifact name.