Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(preload): warn when duplicate requests issued #6849

Merged
merged 1 commit into from
Dec 20, 2018
Merged

Conversation

patrickhulce
Copy link
Collaborator

Summary
We are ignoring URLs to suggest based on what URLs were ever preloaded. This can lead to silent failures where there was a preload request but it wasn't used so the request was reissued. This adds a warning a-la #6694

Related Issues/PRs
ref #6417

@paulirish paulirish merged commit 845cd29 into master Dec 20, 2018
@paulirish paulirish deleted the preload_warning branch December 20, 2018 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants