Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: rename webapp-install-banner audit to installable-manifest #6630

Merged
merged 2 commits into from
Nov 27, 2018

Conversation

brendankenny
Copy link
Member

Part of #6395

Updates webapp-install-banner to be the new installable-manifest audit. SW detection was already deleted from here, so this mostly just updates the id and title and tightens some tests/removes some useless stuff.

@brendankenny brendankenny changed the title core: revise webapp-install-banner audit core: rename webapp-install-banner audit to installable-manifest Nov 22, 2018
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -933,6 +933,25 @@
"scoreDisplayMode": "not_applicable",
"title": "`<input type=\"image\">` elements have `[alt]` text"
},
"installable-manifest": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting why did only these two swap order?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like they're alphabetized. No idea why, but I guess it doesn't matter :) @exterkamp

@brendankenny brendankenny merged commit 3f0a0dd into master Nov 27, 2018
@brendankenny brendankenny deleted the installable branch November 27, 2018 02:01
gangsthub added a commit to gangsthub/WebFundamentals that referenced this pull request Dec 4, 2018
@gangsthub gangsthub mentioned this pull request Dec 4, 2018
4 tasks
kaycebasques pushed a commit to google/WebFundamentals that referenced this pull request Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants