-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clients: skip h2 audit in LR #6564
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixes #6539
we probably need to come up with a way to organize and mark web.dev/API bugs. e.g. this doesn't really fix the problem, it just makes it go away for now :)
@@ -18,6 +18,7 @@ const config = { | |||
throughputKbps: 10 * 1024, | |||
cpuSlowdownMultiplier: 1, | |||
}, | |||
skipAudits: ['uses-http2'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe put a comment, TODO, or link to a bug?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did some simple testing to make sure this is compatible with LR, and seems to work! LGTM
I created the |
fixes #6539
<3 our config.