-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core(locales): streamline hover texts #6508
Changes from 3 commits
f82ee7f
ae81b69
b6f0792
034cf86
1ec2e65
5a3a61e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,7 +12,7 @@ const UIStrings = { | |
/** The name of the metric that marks the time at which the page is fully loaded and is able to quickly respond to user input (clicks, taps, and keypresses feel responsive). Shown to users as the label for the numeric metric value. Ideally fits within a ~40 character limit. */ | ||
title: 'Time to Interactive', | ||
/** Description of the Time to Interactive (TTI) metric, which evaluates when a page has completed its primary network activity and main thread work. This is displayed within a tooltip when the user hovers on the metric name to see more. No character length limits. 'Learn More' becomes link text to additional documentation. */ | ||
description: 'Interactive marks the time at which the page is fully interactive. ' + | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We went with this because the actual moment is called There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, this was my intention to bring the title to first words in the description as everywhere else already. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Would it be better as "Time to interactive is the amount of time it takes for the page to become fully interactive?" Since yea, there is a unit disconnect between a span of time (tti) and a point in time (interactive). nit: What is the capitalization: |
||
description: 'Time to interactive is the amount of time it takes for the page to become fully interactive. ' + | ||
'[Learn more](https://developers.google.com/web/tools/lighthouse/audits/consistently-interactive).', | ||
}; | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes good catch we should definitely change from
The score above
toEstimated Input Latency
👍I'm not sure I like
a rough guess
rather thanan estimate
, that feels like it doesn't give us quite enough credit for how it's computed :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, simply
estimate
is probably more meaningful. I want to avoid the word twice in a sentence. Maybe there's an alternative word around.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I'm not sure about "rough guess" maybe "an approximation"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 on keeping "estimate"