Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(config): add new PWA category groups #6396

Merged
merged 8 commits into from
Oct 26, 2018
Merged

core(config): add new PWA category groups #6396

merged 8 commits into from
Oct 26, 2018

Conversation

brendankenny
Copy link
Member

Starting on #6395

This PR just adds groups to the PWA category and deletes the manifest-short-name-length audit. Feel free to come up with better group descriptions or we can defer, I spent no time on them :)

delete manifest-short-name-length audit
@brendankenny
Copy link
Member Author

Feel free to come up with better group descriptions or we can defer

removed descriptions (since not actually in the mocks), which makes this even easier :)

{id: 'themed-omnibox', weight: 1},
{id: 'content-width', weight: 1},
{id: 'manifest-short-name-length', weight: 0},
// Fast and Reliable
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey this lines up exactly with "most difficult and critical for good UX" :D

do we need to re-order the lines? it lined up with "fast" and then "reliable" already ;)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to re-order the lines?

We don't need to, but since this will end up being a pretty big change in the html report, it seems better to have them in the same order

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, ha, nm, I see what you mean. SGTM :)

@@ -225,6 +224,15 @@ const defaultConfig = {
title: str_(UIStrings.diagnosticsGroupTitle),
description: str_(UIStrings.diagnosticsGroupDescription),
},
'pwa-fast-reliable': {
title: 'Fast and reliable',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we start with these being str_ ? :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we start with these being str_ ?

good call, done

{id: 'webapp-install-banner', weight: 3, group: 'pwa-installable'},

// Engaging
{id: 'redirects-http', weight: 2, group: 'pwa-engaging'}, // Arguably not engaging
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with the new in-yo-face red X insecure I think it works, I'm always a bit taken aback on surge.sh URLs these days on mobile canary!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with the new in-yo-face red X insecure I think it works

ha, fair point. I've removed the comment and anyone who objects can bring it up in the tracking bug :)

Copy link
Member

@paulirish paulirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm % this:

need a slight tweak on PWA category description per the mocks.

'These checks validate the aspects of a Progressive Web App, as specified by the baseline [PWA Checklist](https://developers.google.com/web/progressive-web-apps/checklist).',

⬇️

'These checks validate the aspects of a Progressive Web App. [Learn more](https://developers.google.com/web/progressive-web-apps/checklist)',

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brendankenny brendankenny merged commit 7114406 into master Oct 26, 2018
@brendankenny brendankenny deleted the pwacat branch October 26, 2018 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants