core: update chrome-devtools-frontend to latest #6101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
requested review from
patrickhulce and
paulirish
as code owners
brendankenny
commented
Sep 24, 2018
| * The single prototype augmentation needed from 'chrome-devtools-frontend/front_end/platform/utilities.js'. | ||
| * @return {Array<number>} | ||
| */ | ||
| String.prototype.computeLineEndings = function() { // eslint-disable-line no-extend-native |
There was a problem hiding this comment.
seemed simpler (and more up-front about what we're doing) to explicitly provide the single augmentation we needed rather than all of utilities.js. Since we're up to date now, maybe we could upstream putting this on TextUtils or something, instead :)
(technically computeLineEndings calls String.prototype.findAll in utilities.js, but this reimplements the function so it could be just the one)
patrickhulce
approved these changes
Sep 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update is easy now :) Fulfills the dream of #1535, though the problems it would have fixed back then don't exist anymore.
Hopefully this update will make it easier for whoever takes that last webinspector step, either completely isolating the WebInspector global pollution (cc @castilloandres) or reimplementing the font functionality in Lighthouse. With the updates to the fontend, the first should be quite a bit easier and the second should at least be at least a little easier to follow since the implementation will match current DevTools.