Travis: enable testing of node v4 + --harmony #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
July 8, 2016 14:12
|
Looks a bit hacky in my opinion.. Not sure what the rest thinks |
| @@ -18,9 +19,9 @@ before_script: | |||
| - sleep 5 | |||
| script: | |||
| - npm run lint | |||
| - npm run unit | |||
| - if [[ $(node -v) =~ ^v4.* ]]; then npm run unit:harmony; else npm run unit; fi | |||
There was a problem hiding this comment.
Curious if we could do like a export isNode4=( $(node -v) =~ ^v4.*)
could then do [[ isNode4 ]] && npm run unit:harmony || npm run unit
would feel a little cleaner. :)
There was a problem hiding this comment.
hmmm actually....
i'm seeing a pattern here using matrix that seems a bit smarter: arrizalamin/js-function-reflector/.travis.yml (or this)
There was a problem hiding this comment.
That sounds good, except for the && and ||. I've personally refrained from using them because if npm run unit:harmony fails then npm run unit will be run, which is not what we want.
|
Updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#475