Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report: more attractive table/URL rendering #4190

Merged
merged 6 commits into from
Jan 9, 2018
Merged

report: more attractive table/URL rendering #4190

merged 6 commits into from
Jan 9, 2018

Conversation

paulirish
Copy link
Member

Before and after

image

  1. you can see WAY more of the URL because good CSS.
  2. meanwhile we're more aggressively eliding non-readable strings in the URL

partial fix for #3827 but its not totally complete.

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! so good

do you know how this impacts cells that are in the url column but are actually other types like code? i'm thinking of the css usage audit in particular

element.appendChild(this._renderText({
text: displayedPath,
}));
const hostElem = this._renderText({
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this need to be conditional on displayedHost?

@@ -147,8 +147,15 @@ class Util {
}

const MAX_LENGTH = 64;
// Always elide hash
// Always elide git hash
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about just hex hash :)

// Also elide long number sequences
name = name.replace(/(\d{3})\d{6,}/g, `$1${ELLIPSIS}`);
// Merge any adjacent ellipses
name = name.replace(/\u2026+/g, '\u2026');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\u2026 is ellipsis right, so just pass ELLIPSIS here like the others? :)

@paulirish
Copy link
Member Author

do you know how this impacts cells that are in the url column but are actually other types like code? i'm thinking of the css usage audit in particular

good call!! it wasn't ideal. but after some fixes:

image
image
image

updated.

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 🥀 ➡️ 🌹

@paulirish
Copy link
Member Author

awaiting CI results. when green, land away.

@patrickhulce
Copy link
Collaborator

geez since when did "Unable to connect to Chrome" start failing 100% of the time??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants