Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(smokehouse): Passive event listener violation doesn't report on passive:false now #3498

Merged
merged 2 commits into from
Oct 6, 2017
Merged

test(smokehouse): Passive event listener violation doesn't report on passive:false now #3498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8015b7
test(passive-events): Passive event listener violation doesn't report…
paulirish Oct 6, 2017
79a6a77
add compat msg
paulirish Oct 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lighthouse-cli/test/fixtures/dobetterweb/dbw_tester.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ <h2>Do better web tester page</h2>
console.log('touchstart');
});

// FAIL
// PASS - passive:false doesn't get a warning now. crbug.com/770208
window.addEventListener('mousewheel', function(e) {
console.log('mousewheel');
}, {passive: false});
Expand Down
6 changes: 4 additions & 2 deletions lighthouse-cli/test/smokehouse/dobetterweb/dbw-expectations.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,9 +156,11 @@ module.exports = [
score: false,
extendedInfo: {
value: {
// Note: This would normally be 7 but M56 defaults document-level
// Note: Originally this was 7 but M56 defaults document-level
// listeners to passive. See https://www.chromestatus.com/features/5093566007214080
length: 4,
// Note: It was 4, but {passive:false} doesn't get a warning as of M63: crbug.com/770208
// COMPAT: This can be set to 3 when m63 is stable.
length: '>=3',
},
},
},
Expand Down