--select-chrome and --skip-autolaunch flags removed #2659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
requested changes
Jul 10, 2017
| ]; | ||
| // clang-format on | ||
|
|
||
| return sort(installations, priorities); | ||
| } | ||
|
|
||
| function resolveChromePath() { | ||
| if (canAccess(process.env.CHROME_PATH)) { | ||
| return process.env.CHROME_PATH as string; |
There was a problem hiding this comment.
is the as string necessary here if canAccess() doesn't complain in the line above?
There was a problem hiding this comment.
gotta run, but ya that looks safe:
paulirish
pushed a commit
to GoogleChrome/chrome-launcher
that referenced
this pull request
Aug 29, 2017
GoogleChrome/lighthouse#2659) * --skip-autolaunch flag removed, --select-chrome flag removed * Unused chrome-launcher/ask.ts removed * Added support for CHROME_PATH env variable to replace LIGHTHOUSE_CHROMIUM_PATH * CHROME_PATH env variable documented in CLI help * Added support for CHROME_PATH on macOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2617