Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update smokehouse PWA expectations #2443

Merged
merged 1 commit into from
Jun 6, 2017
Merged

update smokehouse PWA expectations #2443

merged 1 commit into from
Jun 6, 2017

Conversation

brendankenny
Copy link
Member

updates the PWA smokehouse run so that it runs all the latest PWA checks (and will stay current with them going forward) and updates expectations to match

@@ -67,7 +67,7 @@ class ManifestValues extends ComputedArtifact {
{
id: 'shortNameLength',
failureText: 'Manifest `short_name` will be truncated when displayed on the homescreen',
validate: manifest => manifest.value.short_name.value &&
validate: manifest => !!manifest.value.short_name.value &&
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added the !! so that it's always a boolean. If the site had no short_name, this would return undefined which would then get JSON.stringified out of existence in the JSON report

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@brendankenny brendankenny merged commit 4f594d0 into master Jun 6, 2017
@brendankenny brendankenny deleted the smokepwa branch June 6, 2017 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants