Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

give port to plots for new chromelauncher #2284

Merged
merged 2 commits into from
May 17, 2017
Merged

give port to plots for new chromelauncher #2284

merged 2 commits into from
May 17, 2017

Conversation

brendankenny
Copy link
Member

#2246 left this out. #2183 already has this fix, but we may not review it until next week.

paulirish
paulirish approved these changes May 17, 2017
View reviewed changes
Copy link
Member

@paulirish paulirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm.

later we can use launcher.flag and pass that through to lighthouse, but that's a little annoying with the plots code ATM

@paulirish paulirish merged commit 2a64899 into master May 17, 2017
@brendankenny
Copy link
Member Author

yeah, I figure better to wait for #2183

@brendankenny brendankenny deleted the fixplots branch May 17, 2017 04:39
@samccone
Copy link
Contributor

ick, sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulirish paulirish paulirish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brendankenny @samccone @paulirish