misc: correct .npmignore for node >=18.20 #15924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
approved these changes
Apr 5, 2024
paulirish
reviewed
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the weird package-test errors we have been getting recently.
Some change in node 18.20.0 appears to have fixed a bug that our .npmignore was relying on.
Without a leading slash, entries in .npmignore should refer to any file/folder with that name in the directory structure. Before 18.20.0 this wasn't happening for some reason.
I attempted to correct as many entires in our .npmignore as I could, and verified that the contents by diffing [old .npmignore & node 18.19] against [new .npmignore & 18.20]
Ref nodejs/node#52382