Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(dbw): update expectations for unload handler removal #15765

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

adamraine
Copy link
Member

Looks like Chrome has officially pulled the plug on unload handlers. IMO Lighthouse still delivers the correct advice which is flagging the console error for trying to use an unload listener, but not flagging anything in no-unload-listeners audit.

Attempting to use an unload listener creates a permission request now that blocks bfcache, but that is marked pending browser support so could change in a future Chrome patch.

We should remove the no-unload-listeners audit for 12.0, so #15752 is probably unnecessary.

@adamraine adamraine requested a review from a team as a code owner January 16, 2024 21:59
@adamraine adamraine requested review from connorjclark and removed request for a team January 16, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants