-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core(layout-shift-elements): hide audit #15730
Conversation
Can you create an issue for 12.0 to remind us to handle this. |
@@ -258,6 +258,7 @@ Array [ | |||
"largest-contentful-paint", | |||
"largest-contentful-paint-element", | |||
"layout-shift-elements", | |||
"layout-shifts", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this just appearing now? Wouldn't this have been done in the previous PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uh... no idea. It's otherwise passing in another PR w/ latest changes. https://github.com/GoogleChrome/lighthouse/actions/runs/7416263035/job/20180926303?pr=15731#step:12:4250
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but it fails locally for me on main.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So looks like API test is failing on main for me locally. Seems like something weird is going on in CI so this PR LGTM
6123b75
to
0ff259d
Compare
This audit has been replaced by
layout-shifts
#15703Hide it, and we'll likely remove it for 12.0