-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc: improve download-chrome.sh usability #15646
Conversation
5dc949e
to
cf2795c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the cleanup to the yamls is real nice
curl "$url" -Lo chrome.zip && unzip -q chrome.zip | ||
fi | ||
mkdir -p .tmp-download && cd .tmp-download | ||
curl "$url" -Lo chrome.zip && unzip -q chrome.zip && rm chrome.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'd probably just put all these on their own lines
conceivably the -e is equivalent to stringing everything with &&
but i'm sure there's some idiosyncracies that I don't care about. but.. its probably close enough
also no big whoop. i'm fine with &&'s too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
idk why i bothered doing it this way when I normally don't, but fwiw the reason was structural/semantics, dealing with each like thing one line at a time.... little silly
This script wasn't very simple to use locally, and it was more complex than it needed to be for CI. should be better now.