-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core(legacy-javascript): exclude header size for estimating wasted bytes #15640
Merged
Merged
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
f79a1d7
core(legacy-javascript): exclude header size for estimating wasted bytes
connorjclark 8ffd34f
fix roundtrip test
connorjclark a189d10
Merge branch 'main' into legacy-js-headers
connorjclark 5a62627
update sample json, and fix network record roundtrip test
connorjclark 65e104e
fix leg js test
connorjclark 0ecf21f
Update core/audits/byte-efficiency/legacy-javascript.js
connorjclark 3eed1f7
Merge remote-tracking branch 'origin/main' into legacy-js-headers
connorjclark 718e17c
Merge remote-tracking branch 'origin/main' into legacy-js-headers
connorjclark 14b4a7e
fix weird stack overflow bug
connorjclark 718090c
lint
connorjclark File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -135,6 +135,7 @@ class NetworkRequest { | |
|
||
// Go read the comment on _updateTransferSizeForLightrider. | ||
this.transferSize = 0; | ||
this.responseHeadersTransferSize = 0; | ||
this.resourceSize = 0; | ||
this.fromDiskCache = false; | ||
this.fromMemoryCache = false; | ||
|
@@ -344,6 +345,7 @@ class NetworkRequest { | |
this.responseHeadersEndTime = timestamp * 1000; | ||
|
||
this.transferSize = response.encodedDataLength; | ||
this.responseHeadersTransferSize = response.encodedDataLength; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. name is maybe not best, as this (I'm pretty sure) includes SSL/TSL transferred bytes... There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's descriptive, SGTM |
||
if (typeof response.fromDiskCache === 'boolean') this.fromDiskCache = response.fromDiskCache; | ||
if (typeof response.fromPrefetchCache === 'boolean') { | ||
this.fromPrefetchCache = response.fromPrefetchCache; | ||
|
@@ -600,6 +602,15 @@ class NetworkRequest { | |
return reason === 'HSTS' && NetworkRequest.isSecureRequest(destination); | ||
} | ||
|
||
/** | ||
* Returns whether the network request was sent encoded. | ||
* @param {NetworkRequest} record | ||
* @return {boolean} | ||
*/ | ||
static isContentEncoded(record) { | ||
return record.responseHeaders.some(item => item.name === 'Content-Encoding'); | ||
} | ||
|
||
/** | ||
* Resource size is almost always the right one to be using because of the below: | ||
* `transferSize = resourceSize + headers.length`. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: could have a resusable function like
estimateGzipSizeByType
ore something