Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report: use normal gauge if performance score is null #15554

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

adamraine
Copy link
Member

Fixes #15551

We could implement a null case within the explodey gauge, but then we would need a fancy way of displaying an erroneous metric arc which I don't think is worth it. Just showing a normal gauge that already handles this case should be fine.

@adamraine adamraine requested a review from a team as a code owner October 19, 2023 20:26
@adamraine adamraine requested review from connorjclark and removed request for a team October 19, 2023 20:26
@adamraine adamraine merged commit 022f74a into main Oct 19, 2023
29 checks passed
@adamraine adamraine deleted the error-explodey-gauge branch October 19, 2023 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New performance gauge doesn't handle error case
3 participants