Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(fr): use frame url in gather context #13699

Merged
merged 3 commits into from
Feb 25, 2022
Merged

Conversation

adamraine
Copy link
Member

In legacy navigations context.url is the current frame URL and is unaffected by the history API.

However in FR navigations, context.url is the result of page.url() from Puppeteer and is affected by the history API. This can lead to issues in FR navigations where we try and use context.url to get the main document, but context.url is not the URL used to fetch the main document.

This PR ensures context.url reflects the current frame URL without considering any history API calls once we reach the getArtifact phase.


Once we deprecate the legacy navigation runner, I think we should deprecate context.url. Then we can use context.baseArtifacts.URL to get the frame URL and context.driver.url() to get the URL affected by history API.

@adamraine adamraine requested a review from a team as a code owner February 23, 2022 20:14
@adamraine adamraine requested review from connorjclark and removed request for a team February 23, 2022 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants