-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core(fr): add logLevel
to config context
#13681
Conversation
@@ -62,10 +62,10 @@ declare module Config { | |||
* This information is typically set by the CLI or other channel integrations. | |||
*/ | |||
interface FRContext { | |||
gatherMode?: Gatherer.GatherMode; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
drive-by: this shouldn't be exposed on the API. The first thing we do with it is force override with the correct value from whichever runner it's a parameter for.
@@ -22,6 +23,8 @@ const {getBaseArtifacts, finalizeArtifacts} = require('./base-artifacts.js'); | |||
*/ | |||
async function startTimespan(options) { | |||
const {configContext = {}} = options; | |||
log.setLevel(configContext.logLevel || 'error'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could move this into initializeConfig
but it doesn't exactly fit. Running 3 different times isn't too big a deal anyway.
Part of #13680