Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests(page-functions): add test for getNodePath #11433

Merged
merged 2 commits into from
Sep 18, 2020
Merged

tests(page-functions): add test for getNodePath #11433

merged 2 commits into from
Sep 18, 2020

Conversation

paulirish
Copy link
Member

@paulirish paulirish commented Sep 14, 2020 •
edited
Loading

made this when i was noodling on #10956

the PR already had shared authorship, so i thought it best to just split this out separate.

ref #10914

@paulirish paulirish requested a review from a team as a code owner September 14, 2020 18:44
@paulirish paulirish requested review from adamraine and removed request for a team September 14, 2020 18:45
@googlebot

This comment has been minimized.

Sign in to view
@paulirish paulirish force-pushed the getnodepath-shadow-fixandtest-unittest branch from d858974 to 088067b Compare September 14, 2020 18:46
@googlebot

This comment has been minimized.

Sign in to view
@paulirish
Copy link
Member Author

thanks git reset --soft master && git commit && git push --force

connorjclark
connorjclark reviewed Sep 14, 2020
View reviewed changes
lighthouse-core/lib/page-functions.js Outdated Show resolved Hide resolved
lighthouse-core/test/lib/page-functions-test.js Outdated Show resolved Hide resolved
lighthouse-core/test/lib/page-functions-test.js Outdated Show resolved Hide resolved
lighthouse-core/test/lib/page-functions-test.js Outdated Show resolved Hide resolved
@paulirish @connorjclark
Apply suggestions from code review
b194ca7 
Co-authored-by: Connor Clark <cjamcl@google.com>
adamraine
adamraine approved these changes Sep 16, 2020
View reviewed changes
Copy link
Member

@adamraine adamraine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devtools-bot devtools-bot merged commit 0580f57 into master Sep 18, 2020
@devtools-bot devtools-bot deleted the getnodepath-shadow-fixandtest-unittest branch September 18, 2020 00:39
@ryan-ally ryan-ally mentioned this pull request Jun 20, 2023
Open
@HijadelUFO HijadelUFO mentioned this pull request Jul 3, 2023
Open
@cr-icon cr-icon mentioned this pull request Jul 3, 2023
Open
@thexdesk thexdesk mentioned this pull request Jul 4, 2023
Open
@ryan-ally ryan-ally mentioned this pull request Jul 4, 2023
Open
@kalpatarurudra kalpatarurudra mentioned this pull request Jul 5, 2023
Open
@MaxMood96 MaxMood96 mentioned this pull request Jul 5, 2023
Open
@MaxMood96 MaxMood96 mentioned this pull request Nov 26, 2023
Open
@ryan-ally ryan-ally mentioned this pull request Nov 27, 2023
Open
@cr-icon cr-icon mentioned this pull request Nov 28, 2023
Open
@HijadelUFO HijadelUFO mentioned this pull request Nov 28, 2023
Open
@ashubagri ashubagri mentioned this pull request Dec 1, 2023
Open
@kalpatarurudra kalpatarurudra mentioned this pull request Dec 1, 2023
Open
@MaxMood96 MaxMood96 mentioned this pull request Dec 2, 2023
Open
@thexdesk thexdesk mentioned this pull request Dec 3, 2023
Open
@HijadelUFO HijadelUFO mentioned this pull request Dec 3, 2023
Open
@ryan-ally ryan-ally mentioned this pull request Dec 3, 2023
Open
@cr-icon cr-icon mentioned this pull request Dec 5, 2023
Open
@cr-icon cr-icon mentioned this pull request Dec 13, 2023
Open
@ashubagri ashubagri mentioned this pull request Dec 15, 2023
Open
@kalpatarurudra kalpatarurudra mentioned this pull request Jan 2, 2024
Open
@MaxMood96 MaxMood96 mentioned this pull request Jan 5, 2024
Open
@thexdesk thexdesk mentioned this pull request Feb 25, 2024
Open
@HijadelUFO HijadelUFO mentioned this pull request Mar 1, 2024
Open
@ryan-ally ryan-ally mentioned this pull request Mar 6, 2024
Open
@kalpatarurudra kalpatarurudra mentioned this pull request May 14, 2024
Open
@cr-icon cr-icon mentioned this pull request May 14, 2024
Open
@HijadelUFO HijadelUFO mentioned this pull request May 15, 2024
Open
@ryan-ally ryan-ally mentioned this pull request May 15, 2024
Open
@kalpatarurudra kalpatarurudra mentioned this pull request May 15, 2024
Open
@cr-icon cr-icon mentioned this pull request May 16, 2024
Open
@ashubagri ashubagri mentioned this pull request May 16, 2024
Open
@MaxMood96 MaxMood96 mentioned this pull request May 16, 2024
Open
@thexdesk thexdesk mentioned this pull request May 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@connorjclark connorjclark connorjclark left review comments

@adamraine adamraine adamraine approved these changes

Assignees

@adamraine adamraine

Labels
cla: yes waiting4reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@paulirish @googlebot @connorjclark @adamraine @devtools-bot