Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opn is deprecated, switch to open #9265

Closed
jamesgeorge007 opened this issue Jun 24, 2019 · 2 comments · Fixed by #9267
Closed

opn is deprecated, switch to open #9265

jamesgeorge007 opened this issue Jun 24, 2019 · 2 comments · Fixed by #9267

Comments

@jamesgeorge007
Copy link
Contributor

Summary
opn is deprecated and renamed to open. But, it isn't compatible with node-js version 6.

@patrickhulce
Copy link
Collaborator

Thanks @jamesgeorge007! Interested in moving us there? :)

For any potential implementers, node version 6 compat is not an issue for us because we only support node 10 LTS moving forward.

@patrickhulce
Copy link
Collaborator

Looks like just lighthouse-cli/run.js! Though we apparently reference it in our README as well.

> grep -rE "\bopn\b" --exclude-dir=node_modules .
./changelog.md:* b2ccdfcb Allow opn & update-notifier CLI deps to be optional. (#2150)
./changelog.md:- Add [`opn`](https://www.npmjs.com/package/opn) - #1130
./docs/readme.md:| `view` | Ignored, use the `opn` npm module if you want this functionality. |
./yarn.lock:"@types/opn@^3.0.28":
./yarn.lock:  resolved "https://registry.yarnpkg.com/@types/opn/-/opn-3.0.28.tgz#097d0d1c9b5749573a5d96df132387bb6d02118a"
./yarn.lock:    opn "4.0.2"
./yarn.lock:opn@4.0.2:
./yarn.lock:  resolved "https://registry.yarnpkg.com/opn/-/opn-4.0.2.tgz#7abc22e644dff63b0a96d5ab7f2790c0f01abc95"
./package.json:    "@types/opn": "^3.0.28",
./package.json:    "opn": "4.0.2",
./lighthouse-cli/run.js:const opn = require('opn');
./lighthouse-cli/run.js:        opn(outputPath, {wait: false});

jamesgeorge007 added a commit to jamesgeorge007/lighthouse that referenced this issue Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants